1705019 - Make LOG profiler markers always enabled when MOZ_LOG is enabled

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P3)

Description

[Julien Wajsberg [:julienw]]

Currently, enabling profiler markers with MOZ_LOG requires that we add profilermarkers in the MOZ_LOG string. This is both cumbersome and badly discoverable, and doesn't interact well with other debugging tools like about:networking.

So in this bug we want to enabled the profiler markers all the time, as long as both MOZ_LOG is enabled and the profiler is running.

Related code is:
https://searchfox.org/mozilla-central/rev/759872688df15a5d6ab305ffe39d90450590bfec/xpcom/base/Logging.cpp#400-401
https://searchfox.org/mozilla-central/rev/759872688df15a5d6ab305ffe39d90450590bfec/xpcom/base/Logging.cpp#599
and other code referencing these variables.

This should be quite straightforward.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1705019 - Always record LogMessage profiler markers for enabled log messages when the profiler is enabled and add a new 'profilerstacks' keyword to enable capturing stacks in these markers, r=mstange.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/815e56c1a0d0
Always record LogMessage profiler markers for enabled log messages when the profiler is enabled and add a new 'profilerstacks' keyword to enable capturing stacks in these markers, r=mstange.

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/815e56c1a0d0