firefoxtree loses magic named revision reference when doing a partial pull
Categories
(Developer Services :: Mercurial: firefoxtree, defect)
Tracking
(Not tracked)
People
(Reporter: Gijs, Unassigned)
Details
Context: I primarily use artifact builds at the moment. There is often a merge shortly after I start work in the morning (around 10-10.30 utc). If I pull central at that point and try to use an artifact build, the artifacts for that revision of central won't be ready, which can lead to bugs and/or broken behaviour and a wild goose chase trying to figure out what is causing them -- or at least re-downloading newer artifacts at a later point in the day when I re-run mach build.
To avoid this, today I tried to run:
hg pull -r <blah> central
on my mozilla-unified repo.
This successfully pulled changes up to the revision I specified, but it lost the fxtree central reference completely (it now just tells me abort: unknown revision: 'central').
In this case, I would expect central to point to the tipmost central revision I pulled.
|
||
Comment 1•4 years ago
|
||
This bug is the result of an odd edge case in the firefoxtree extension, due to an internal library that maps named shortcuts for some known Firefox repos to their respective https URLs. In this case, when you ran hg pull -r <blah> central, the internals of firefoxtree turned that command into hg pull -r <blah> https://hg.mozilla.org/mozilla-central. Pulling from mozilla-central directly instead of mozilla-unified likely confused firefoxtree, since pulling from unified causes the firefoxtree "tags" to be set on your local machine based on the Mercurial bookmarks on the server, whereas pulling from central directly causes the tip-most revision to be set as the firefoxtree tag. Mixing these two use cases is likely causing some odd interaction, as they weren't intended to be mixed as far as I am aware.
To work around this odd behaviour, I'd suggest trying hg pull && hg up -r <blah>, which will pull the entire tree and update to the central changeset <blah> which you know has artifacts available. Running hg pull should also recover the central tag for you.
Description
•