1705038 - When dragging recipient input text, uncaught TypeError: event.originalTarget.closest is not a function

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Thomas D. (:thomas8)]

Starting to drag plain text from a recipient input field causes console error.

STR

1. compose, type hello into To field (then realize that you wanted to type that into subject)
2. select and drag hello into subject

Actual

• console error (89.0a1 (2021-04-12) (64-bit))

Uncaught TypeError: event.originalTarget.closest is not a function
    connectedCallback chrome://messenger/content/mailWidgets.js:2268
mailWidgets.js:2268:47

Expected

• no console error

Analysis

• closest() is only available for Element nodes, but originalTarget of selected input text is a text node (hence the error)
• originalTarget should go away per bug 1699809
• For our scenario, target when dragging selected plain text will be <html:input> (also when editing pill); need to adjust selector accordingly.

Comment 1

[Thomas D. (:thomas8)]

Attachment: 1705038_fixRecipientInputTextDragError.diff

Bug 1705038 - Fix uncaught TypeError when dragging recipient input text. r=aleca

For our dragstart target pill selector (which checks if we're dragging pills):

• Don't use originalTarget which can be a text node which does not have closest().
• Make sure that we're not dragging plain text from a pill in editing mode.

Also remove an unnecessary check for an unpredictable number of selected pills.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9215741 [details] [diff] [review]
1705038_fixRecipientInputTextDragError.diff

Review of attachment 9215741 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f6f294aa7802
Fix uncaught TypeError when dragging recipient input text. r=aleca