Closed Bug 1705071 Opened 4 years ago Closed 3 years ago

Remove handling of X_IS_MOBILE in nginx

Categories

(Cloud Services :: Operations: AMO, task)

task

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mat, Assigned: wezhou)

Details

We no longer need to detect and pass X_IS_MOBILE header to addons-server or addons-frontend.

In addition, we no longer need the Vary on User-Agent on addons-server (olympia). We still need it on addons-frontend, but I'm going to write a patch to set it from addons-frontend code directly instead of having to set it in nginx config (https://github.com/mozilla/addons-frontend/issues/10381).

This is not urgent so it's worth waiting for https://github.com/mozilla/addons-frontend/issues/10381 to land in prod so that we can completely remove the add_header Vary User-Agent from nginx config for both addons-server and addons-frontend.

I opened https://github.com/mozilla-services/cloudops-deployment/pull/4289 to change the nginx config for this.

https://github.com/mozilla-services/cloudops-deployment/pull/4289 is merged and pushed to -dev and -stage.

Please test it and let us know how it works.

This is deployed to -prod today.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.