Closed Bug 1705137 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 28475 - [LayoutNG] Nested fixedpos in a nested multicol

Categories

(Core :: Layout: Columns, task, P4)

task

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28475 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28475
Details from upstream follow.

b'Alison Maher <almaher@microsoft.com>' wrote:

[LayoutNG] Nested fixedpos in a nested multicol

Previously, if a nested fixedpos was in a nested multicol, and the
containing block was the viewport, it was never laid out. To fix this,
propagate any OOF candidates found when performing layout of OOFs in an
inner multicol to ensure that any nested candidates bubble up to the
correct containing block.

Bug: 1188756
Change-Id: If5ff481d25c24f693575faf7309eae8cb5a37ba1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2823871
Commit-Queue: Alison Maher \<almaher@microsoft.com>
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#872442}

Component: web-platform-tests → Layout: Columns
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

PASS: 2

Safari

PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-multicol/fixed-in-nested-multicol-with-viewport-container.html: FAIL

New Tests That Don't Pass

/css/css-multicol/fixed-in-nested-multicol-with-viewport-container.html: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db360ba6d82e
[wpt PR 28475] - [LayoutNG] Nested fixedpos in a nested multicol, a=testonly
https://hg.mozilla.org/integration/autoland/rev/ef05ee6f47d0
[wpt PR 28475] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.