Closed Bug 1705147 Opened 6 months ago Closed 6 months ago

Make it possible to use WebSocket outside Window/Worker scopes

Categories

(Core :: DOM: Networking, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(1 file)

No description provided.
Component: MathML → DOM: Networking
Severity: -- → N/A
Type: defect → enhancement
Priority: -- → P5

Could you try the patch?

Flags: needinfo?(hskupin)

Yes, I'll have a look at it.

Blocks: 1704998

Olli, this works fine locally for me. As such I pushed a try build with the additional change for the Remote Agent to use the WebSocket no longer via the hidden window. This build contains all the relevant tests that were completely failing before.

https://treeherder.mozilla.org/jobs?repo=try&revision=fb11ffd416175397b8b1bcd3bf19657fa368de9d

Flags: needinfo?(hskupin)

Also the try build looks fine and tests are all passing across platforms. I pushed another try build that also includes my build config changes to make the Remote Agent available on Android. I would like to test quickly if a WebSocket connection can be established now. As such I will report back shortly.

I have verified that with the changes on this bug the Remote Agent can perfectly create a WebSocket server by not using the hidden window.

With all that the whole CDP browser-chrome test-suite and Puppeteer tests can currently be used to verify this change. This would also apply to any upcoming Webdriver spec related test under the following folder:

https://searchfox.org/mozilla-central/source/testing/web-platform/tests/webdriver/tests/bidi

Olli, is there anything else I could help with? If not thanks a lot for helping us to get this fixed, and I hope that this patch can be landed.

Flags: needinfo?(bugs)

Let me try get the patch reviewed then :)

Flags: needinfo?(bugs)
Assignee: nobody → bugs
Status: NEW → ASSIGNED
Attachment #9215828 - Attachment description: WIP: Bug 1705147 - Make it possible to use WebSocket outside Window/Worker scopes → Bug 1705147 - Make it possible to use WebSocket outside Window/Worker scopes, r=baku
Whiteboard: [bidi-m1-mvp]
Whiteboard: [bidi-m1-mvp]
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c4873576e7d1
Make it possible to use WebSocket outside Window/Worker scopes, r=asuth
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.