1705147 - Make it possible to use WebSocket outside Window/Worker scopes

Status: RESOLVED FIXED

(Core :: DOM: Networking, enhancement, P5)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1705147 - Make it possible to use WebSocket outside Window/Worker scopes, r=baku

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Could you try the patch?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yes, I'll have a look at it.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Olli, this works fine locally for me. As such I pushed a try build with the additional change for the Remote Agent to use the WebSocket no longer via the hidden window. This build contains all the relevant tests that were completely failing before.

https://treeherder.mozilla.org/jobs?repo=try&revision=fb11ffd416175397b8b1bcd3bf19657fa368de9d

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Also the try build looks fine and tests are all passing across platforms. I pushed another try build that also includes my build config changes to make the Remote Agent available on Android. I would like to test quickly if a WebSocket connection can be established now. As such I will report back shortly.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I have verified that with the changes on this bug the Remote Agent can perfectly create a WebSocket server by not using the hidden window.

With all that the whole CDP browser-chrome test-suite and Puppeteer tests can currently be used to verify this change. This would also apply to any upcoming Webdriver spec related test under the following folder:

https://searchfox.org/mozilla-central/source/testing/web-platform/tests/webdriver/tests/bidi

Olli, is there anything else I could help with? If not thanks a lot for helping us to get this fixed, and I hope that this patch can be landed.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Let me try get the patch reviewed then :)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4873576e7d1
Make it possible to use WebSocket outside Window/Worker scopes, r=asuth

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c4873576e7d1