1705155 - Update dav1d to new version 54ad561dfa8d5b450caa2fecc741ca6c44b80e7a from 2021-04-14 14:57:30

Status: RESOLVED DUPLICATE of bug 1705917

(Core :: Audio/Video: Playback, enhancement)

Description

[Update Bot]

This update covers 7 commits:

---

7f5759744dd3fbcc7bf34244f945551a2f25ecd6 by Martin Storsjö

https://code.videolan.org/videolan/dav1d-/commit/7f5759744dd3fbcc7bf34244f945551a2f25ecd6
Authored: 2021-03-16 08:42:30 +0200
Committed: 2021-03-16 14:01:46 +0200

checkasm: Drop one layer of macro expansion for concatenation

The usual two-layer macro expansion for concatenation isn't needed
here, as the parameters that needs expanding (PIXEL_TYPE, COEF_TYPE)
end up expanded by the intermediate checkasm_check() macro anyway.

Files Added:

• tests/checkasm/checkasm.h

---

ae8958bdc7d30847158eafcec14552213708402f by Matthias Dressel

https://code.videolan.org/videolan/dav1d-/commit/ae8958bdc7d30847158eafcec14552213708402f
Authored: 2021-04-02 15:45:28 +0200
Committed: 2021-04-12 20:18:03 +0000

CI: Fix asm checks

meson 0.57.0 introduced an optimization [0] for meson test to only
rebuild test dependencies. This does not cover changing the build
configuration anymore.

[0] https://mesonbuild.com/Release-notes-for-0-57-0.html

Files Added:

• .gitlab-ci.yml

---

ffb347eecdbf2d4f6b3e1c3c28966d4a779be9e1 by Martin Storsjö

https://code.videolan.org/videolan/dav1d-/commit/ffb347eecdbf2d4f6b3e1c3c28966d4a779be9e1
Authored: 2021-03-20 00:22:25 +0200
Committed: 2021-04-14 14:57:30 +0000

filmgrain: Use the BITDEPTH_MAX macro and round2 helper function

The fgy function already used the round2 helper function in this way.

Files Added:

• src/film_grain_tmpl.c

---

ca29d17901db5d4ebdcac7b0832685c775e3fbef by Martin Storsjö

https://code.videolan.org/videolan/dav1d-/commit/ca29d17901db5d4ebdcac7b0832685c775e3fbef
Authored: 2021-03-21 17:09:58 +0200
Committed: 2021-04-14 14:57:30 +0000

checkasm: filmgrain: Check all overlap combinations in each run

Previously, only some combinations of overlap were tested in each run.

Also benchmark with and without overlap.

Files Added:

• tests/checkasm/filmgrain.c

---

5407eaf2e69f7d17b0a14b8db390604d0f557025 by Martin Storsjö

https://code.videolan.org/videolan/dav1d-/commit/5407eaf2e69f7d17b0a14b8db390604d0f557025
Authored: 2021-03-24 14:21:37 +0200
Committed: 2021-04-14 14:57:30 +0000

attributes: Add a CHECK_OFFSET macro for verifying struct offsets

A static_assert is used if available, otherwise a custom
construct.

Files Added:

• include/common/attributes.h

---

90bcb3314124d988992485aeb4bcd900904ef472 by Martin Storsjö

https://code.videolan.org/videolan/dav1d-/commit/90bcb3314124d988992485aeb4bcd900904ef472
Authored: 2021-03-15 14:26:09 +0200
Committed: 2021-04-14 14:57:30 +0000

arm64: filmgrain: Add NEON implementation of the fguv function

Relative speedup over C code:
Cortex A53 A72 A73 Apple M1
fguv_32x32xn_8bpc_420_csfl0_neon: 4.51 2.87 3.88 6.51
fguv_32x32xn_8bpc_420_csfl1_neon: 3.74 2.96 2.96 3.49
fguv_32x32xn_8bpc_422_csfl0_neon: 4.49 3.18 4.07 5.00
fguv_32x32xn_8bpc_422_csfl1_neon: 3.74 3.03 3.04 2.67
fguv_32x32xn_8bpc_444_csfl0_neon: 6.68 4.24 5.66 5.02
fguv_32x32xn_8bpc_444_csfl1_neon: 5.40 3.69 4.22 3.61

Files Added:

• src/arm/asm-offsets.h

Files Added:

• src/arm/64/film_grain.S
• src/arm/film_grain_init_tmpl.c

---

54ad561dfa8d5b450caa2fecc741ca6c44b80e7a by Martin Storsjö

https://code.videolan.org/videolan/dav1d-/commit/54ad561dfa8d5b450caa2fecc741ca6c44b80e7a
Authored: 2021-03-22 13:18:52 +0200
Committed: 2021-04-14 14:57:30 +0000

arm64: filmgrain: Share the prologue of the fgy function

This is the same as what was done for the fguv function, to reduce
the amount of space used for it (and also simplifying the calling
code).

This gives no significant slowdown for the case currently benchmarked
by checkasm, while shrinking the code produced by film_grain.S by
320 bytes.

Files Added:

• src/arm/64/film_grain.S
• src/arm/film_grain_init_tmpl.c

---

Comment 1

[Update Bot]

./mach vendor %s failed

Comment 2

[Tom Ritter [:tjr] (OOTO until 7/21)]

Resolved the prior bugs into a dupe chain manually. Will need to add that feature so Updatebot can do it automatically. We will also need to fix the ./mach vendor failure message.