1705197 - Remove uses of JSID_TO_ATOM in js/src/vm directory

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P5)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Note: this bug is currently reserved for Outreachy applicants for the Spring/Summer 2021 cycle. If it has not been completed by the end of the application cycle, we will open it up.

Background

The JSID_TO_ATOM calls reflect an old style of SpiderMonkey programming that we think we can start to get away from, at internally to the engine.

This Bug

This bug is about removing uses of JSID_TO_ATOM within the js/src/vm directory. You can find these uses using your editor search functionality, or SearchFox. Instead of using JSID_TO_ATOM we should be using JS::PropertyKey::toAtom, which is actually how JSID_TO_ATOM is implemented.

Prerequisites

Before getting started, you'll want to

• You Have a checkout of the Firefox source code
• Make sure you can build and test SpiderMonkey
• Read this walkthrough about how development works in Firefox

How you’ll know you’re done

• The use of JSID_TO_ATOM is removed in the specified places.
• SpiderMonkey builds
• The tests run successfully.

Getting Help

Feel free to leave comments on this bug for questions, or, if you have more synchronous questions about this bug, feel free to drop into the #spidermonkey channel on chat.mozilla.org.

Tips:

• Not sure if the code you've been editing is getting run? Insert a call to MOZ_CRASH, a macro which will crash when executed, and run the entire test suite with an optimized build (for speed). If you see crashes, you can then use a debug build to make sure it's crashing in your code!

Comment 1

[Jane Kotovich (:janey)]

Hey! It's Jane from Outreachy. I just finished my work on similar bug and would love to grab this one for work!
Especially when mine SpiderMonkey works great and I do have now correct code.
Thanks heaps! Looking forward to work on this one!

Comment 2

[Garima Mazumdar]

Hi! Thanks for recommending me this bug, I'll definitely get started with it :)

Comment 3

[Garima Mazumdar]

Hi, just had a few doubts about setting up SpiderMonkey. They've mentioned a directory $HOME/mozconfigs, so is HOME c:/mozilla-source/mozilla-unified? Also, how does my system know what HOME is? Do I have to set up an environment variable for it? Also, for building, they've mentioned cd <path to mozilla-central>, however, I don't have any mozilla-central? (I'm working on windows, if it matters)
Just wanted to get these doubts clarified before building :)

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Looks like you got that answered in #spidermonkey :) Cheers.

Comment 5

[Garima Mazumdar]

Hi Matthew! I've made the necessary changes, but I wanted to test the code first, and tried running "./mach test js/src/vm/" but it says UNKNOWN TEST, so what should I do now?

Comment 6

[Garima Mazumdar]

Attachment: Bug 1705197 Remove uses of JSID_TO_ATOM in js/src/vm directory. r?mgaudet

Comment 7

[Matthew Gaudet (he/him) [:mgaudet]]

Hey Garima;

See this link for details, but in general just running all the jit-tests should suffice.

Comment 8

[Garima Mazumdar]

Hey Matthew,
Yeah I ran jit-test and mach build before submitting the patch and everything seemed to be working fine, do let me know if I've made any errors or if I have to make any changes :)

Comment 9

[Matthew Gaudet (he/him) [:mgaudet]]

(no need to need-info on every email).

I'll take a look and review when I get a minute!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcf3680823bf
Remove uses of JSID_TO_ATOM in js/src/vm directory. r=mgaudet

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/dcf3680823bf