1705221 - Make browser/components/places/tests/browser/browser_stayopenmenu.js work with native context menus

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task)

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1705221 - Use activateItem instead of keyboard activation when opening a new tab using the context menu. r=harry

On platforms with non-native context menus, there's one potential bug that we
might miss with this change: If there is a bug with keyboard handling that
causes the hamburger menu to close even though we only wanted to activate the
menu.
But this test mostly seems to care about accidental menu closures in response to
mouse events.

With native menus, keyboard events cannot be synthesized at menus.

Furthermore, if the user uses the keyboard to interact with native menus, the
system handles those keyboard events and we never see them. And since we do not
see them, this also means that we cannot accidentally close any of our own menus
in response to them, so the potential bug that I outlined above cannot happen.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f59f0fced578
Use activateItem instead of keyboard activation when opening a new tab using the context menu. r=harry

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f59f0fced578