Closed Bug 1705229 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 28488 - Consider HasOverflow true as valid scenario for HandleAtomicInline

Categories

(Core :: Layout: Text and Fonts, task, P4)

Product:
Core
Component:
Layout: Text and Fonts
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28488 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28488
Details from upstream follow.

b'Javier Fern\xc3\xa1ndez Garc\xc3\xada-Boente <jfernandez@igalia.com>' wrote:

Consider HasOverflow true as valid scenario for HandleAtomicInline

The table caption element always have 0 available space, since its text
consumes all of it. Hence, adding an empty span with negative margins
may imply the line to overflow. If we add some atomic-inline elements
in such caption, we might need to process them under the scenario of a
NGInlineInfo which has true sa HasOverflow flag.

In the current code, there is an assertion that under kContinue state
and negative remaining_width (implying overflow) it's not valid to have
the line-info's HasOverflow flag to true.

I believe this assertion is contradictory and that this is indeed a
valid scenario, hence, this CL removes such assertion.

Bug: 1197974
Change-Id: I80c48e5dffe5e5ee25fcb4cc15db02d584adc4b9
Reviewed-on: https://chromium-review.googlesource.com/2821314
WPT-Export-Revision: ecea8703f2bca87ec790e122ee428d54323266da

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8071e722c442
[wpt PR 28488] - Consider HasOverflow true as valid scenario for HandleAtomicInline, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8071e722c442

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.