Closed Bug 1705238 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 28494 - [LayoutNG] OOF positioned offset in a nested multicol

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28494 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28494
Details from upstream follow.

b'Alison Maher <almaher@microsoft.com>' wrote:

[LayoutNG] OOF positioned offset in a nested multicol

OOF positioned elements (abspos or fixedpos) in a nested multicol
could get the wrong offset if the containing block started in a column
that was not the first in a given multicol fragment. The reason being
that we had adjusted the containing block offset in CL:2680070 to take
into account columns from previous fragments. However, if the containing
block was not in the first column in a multicol fragment, we would have
already adjusted for this in NGContainerFragmentBuilder (given that its
column's builder would have access to the previous column break token).

To fix this, utilize the previous_break_token_ stored in
NGBoxFragmentBuilder (which is available in both cases above) to
determine the correct offset for the containing block. This is now
updated via NGBoxFragmentBuilder::AdjustOffsetForFragmentainer().

Bug: 1198578
Change-Id: I3c183dd83ed45e240fb9f62347dd388e370b1510

Reviewed-on: https://chromium-review.googlesource.com/2822985
WPT-Export-Revision: 7636011556dfbbd476f779e08231b77b3c0b9ae8

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a6d746e60eac
[wpt PR 28494] - [LayoutNG] OOF positioned offset in a nested multicol, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.