Closed Bug 1705246 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 28497 - [LayoutNG] Fixepos offset in a nested multicol

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28497 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28497
Details from upstream follow.

b'Alison Maher <almaher@microsoft.com>' wrote:

[LayoutNG] Fixepos offset in a nested multicol

When a fixedpos is nested in another OOF inside a nested multicol,
and the outer OOF is not positioned at top:0 inside the containing
block of the fixedpos, the offset of the fixedpos was incorrect. The
reason being that its static position was getting updated in
NGContainerFragmentBuilder::PropagateOOFPositionedInfo() to take the
offset of the OOF into account. This change makes sure that
the static position no longer adds in this offset and instead is
relative to its containing block.

Bug: 1198672
Change-Id: I79ec28a036637b4a985fe41752be323845b8c440
Reviewed-on: https://chromium-review.googlesource.com/2827007
WPT-Export-Revision: efde4e7b0fd05161378c4da517cd3eeabdacca14

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

FAIL: 2

Safari

FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-break/out-of-flow-in-multicolumn-039.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/98d55c60fd3e
[wpt PR 28497] - [LayoutNG] Fixedpos offset in a nested multicol, a=testonly
https://hg.mozilla.org/integration/autoland/rev/ae1db75b0bb3
[wpt PR 28497] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/98d55c60fd3e
https://hg.mozilla.org/mozilla-central/rev/ae1db75b0bb3

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.