Closed Bug 1705279 Opened 3 years ago Closed 3 years ago

Intermittent [tier2] gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | Test timed out. -

Categories

(Core :: Panning and Zooming, defect, P5)

defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: tnikkel)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Filed by: dluca [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=336581192&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/fiq9X56ZRsqiBAQls3zqXA/runs/0/artifacts/public/logs/live_backing.log


INFO - TEST-PASS | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | Starting subtest helper_checkerboard_zoomoverflowhidden.html 
[task 2021-04-15T02:37:28.812Z] 02:37:28     INFO - TEST-PASS | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | helper_checkerboard_zoomoverflowhidden.html | The initial_resolution is 1, which is some sane value 
[task 2021-04-15T02:37:28.812Z] 02:37:28     INFO - TEST-PASS | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | helper_checkerboard_zoomoverflowhidden.html | expected at least one nonempty paint 
[task 2021-04-15T02:37:28.812Z] 02:37:28     INFO - TEST-PASS | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | helper_checkerboard_zoomoverflowhidden.html | subframe should be layerized at this point 
[task 2021-04-15T02:37:28.812Z] 02:37:28     INFO - TEST-PASS | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | helper_checkerboard_zoomoverflowhidden.html | subframe should have a scroll id 
[task 2021-04-15T02:37:28.812Z] 02:37:28     INFO - TEST-PASS | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | helper_checkerboard_zoomoverflowhidden.html | The final resolution (3.0922749042510986) is greater than the initial resolution 
[task 2021-04-15T02:37:28.812Z] 02:37:28     INFO - Buffered messages finished
[task 2021-04-15T02:37:28.812Z] 02:37:28     INFO - TEST-UNEXPECTED-FAIL | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | Test timed out. - 
[task 2021-04-15T02:37:29.668Z] 02:37:29     INFO - GECKO(2153) | MEMORY STAT | vsize 6585MB | residentFast 83MB | heapAllocated 8MB
[task 2021-04-15T02:37:31.834Z] 02:37:31     INFO - TEST-OK | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | took 331258ms
[task 2021-04-15T02:37:35.143Z] 02:37:35     INFO - Error: Unable to restore focus, expect failures and timeouts.
[task 2021-04-15T02:37:35.143Z] 02:37:35     INFO - TEST-START | gfx/layers/apz/test/mochitest/test_group_double_tap_zoom.html```

Confirmed via Try that this is a regression from bug 1704231.

Regressed by: overscroll-nightly
Has Regression Range: --- → yes
Keywords: regression

This seems to be perma fail on mac right now? Meaning we are currently losing apz (and other area) and every test that comes after this test coverage on mac.

In the Tier 2 WebRender suite, yes.

Flags: needinfo?(botond)

Which is the only suite of mochitests we run on mac. Anyways it seems it only almost perma fail on opt. We get some good runs on debug still.

I tried reproducing the failure locally on Linux (with overscroll enabled manually), but wasn't able to.

Timothy or Hiro, could you check if you can reproduce the failure locally on Mac? If so, it may be more efficient to investigate it locally rather than via Try.

Flags: needinfo?(tnikkel)
Flags: needinfo?(hikezoe.birchill)

Note, a local repro may need --enable-webrender as all failures so far are with WR.

Reproduces with and without wr.

Seems like we are waiting for this promise to resolve

https://searchfox.org/mozilla-central/rev/6a41d8d7ad42d57cf1adcc7067fd8f1689c42ab3/gfx/layers/apz/test/mochitest/helper_checkerboard_zoomoverflowhidden.html#86

We are trying to use those touch events to scroll up and to the left. The test seems to stop when we reach the top but haven't yet reach the left. So overscroll in the vert direction makes something go wrong?

Flags: needinfo?(tnikkel)

So we zoom in, pan up and to the left to return to 0,0, then pan down and right.

During the pan up and left we are in state 3 for APZC 1 (we get many "got a touch-move in state 3"). Eventually those lead to:

APZC 2 dropping handoff; AllowImmediateHandoff=false
(1) APZC 2 taking overscroll during panning

Eventually the touch-move finish and we get "got a touch-move in state 3" and the handoff and overscroll messages stop too. APZC 1 changes state to NOTHING. APZC 2 changes state to OVERSCROLL_ANIMATION:

APZC 2 is overscrolled, starting snap-back
APZC 2 changing from state 0 to 9

We finish waiting for the promises falling the pan up and to the left call in the test and we send the pan down and to the right in the test, APZC 2 is still in state OVERSCROLL_ANIMATION. This seems to trigger APZC going into state NOTHING:

APZC 2 running CancelAnimation(0x3) in state 9

Now APZC 2 starts getting touch-moves it goes into state TOUCHING and then PANNING_LOCKED_X, it gets touch-end and goes into state NOTHING. We then get:

APZC 2 is overscrolled, starting snap-back
APZC 2 changing from state 0 to 9

again. And then we changes to state NOTHING and we are stuck waiting for a touch-end promise, even though we got the touch-end msg in the log. So perhaps apzc2 is the wrong place?

Comparing this to overscroll disabled we are different: at point (1) above we also get the "taking overscroll during panning" for APZC 1. We never go into state 9. and APZC 1 gets the touch moves and is in state 4, not APZC 2.

So maybe the touches for the pan down and to the right end up in the gutter and go to the wrong apzc?

APZC 2 is the rcd, APZC 1 is something else.

Flags: needinfo?(hikezoe.birchill)
Assignee: nobody → tnikkel
Status: NEW → ASSIGNED
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1811dfb4d3f5
Move test coords slightly in gfx/layers/apz/test/mochitest/helper_checkerboard_zoomoverflowhidden.html to avoid overscroll gutter. r=botond
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: