1705281 - Remove scheduled task(s) in first run (including backgroundupdate task)

Status: RESOLVED FIXED

(Toolkit :: Application Update, task)

Description

[Nick Alexander :nalexander [he/him]]

Spinning out part of Bug 1698593. We've run into complications removing background tasks in the uninstaller, but part of the patch series seems fine -- removing left over background tasks in the first run invocation. This ticket will land that while we hammer out the uninstaller bits.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1705281 - Pre: Use EXIT_CODE in BackgroundTask_{success,failure}. r?#application-update-reviewers

This probably should have been part of the cleanup commit
https://hg.mozilla.org/mozilla-central/rev/673745818480.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1705281 - Part 1: Accommodate exceptions in `deleteAllTasks`; don't try to delete WDBA task. r?agashlin

It makes sense to accommodate exceptions in deleteAllTasks: since
we're trying to clean up, do as much as possible. It's possible that
we should catch, store, and re-throw any exception rather than trying
to delete a second time, but it's not clear how that re-thrown
exception will present in the browser console, etc.

We special case the WDBA task in the task scheduler implementation
rather than having consumers accommodate it because the task is the
outlier that behaves differently from the rest of the task scheduler,
and because we don't anticipate additional outlier tasks in the
future.

Depends on D110784

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1705281 - Part 2: Remove any scheduled task(s) on first startup. r?agashlin!,mconley!

This is best effort. For example, we can't handle the situation where
multiple OS-level users have scheduled tasks from a previous
installation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/555c08322816
Pre: Use EXIT_CODE in BackgroundTask_{success,failure}. r=application-update-reviewers,bytesized
https://hg.mozilla.org/integration/autoland/rev/62bd2c72a288
Part 1: Accommodate exceptions in `deleteAllTasks`; don't try to delete WDBA task. r=agashlin
https://hg.mozilla.org/integration/autoland/rev/8ce8382dafb7
Part 2: Remove any scheduled task(s) on first startup. r=agashlin,mconley

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/555c08322816
https://hg.mozilla.org/mozilla-central/rev/62bd2c72a288
https://hg.mozilla.org/mozilla-central/rev/8ce8382dafb7