Closed Bug 1705346 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 28503 - [Credentialless]: Make fetch.tentative.https.html more reliable.

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28503 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28503
Details from upstream follow.

b'arthursonzogni <arthursonzogni@chromium.org>' wrote:

[Credentialless]: Make fetch.tentative.https.html more reliable.

Previously, the test was assuming the window can be closed immediately
after sending the last fetch request.
This is not true, because closing the window might interrupt previously
scheduled fetch requests and fails the test.
We need to wait for the test completion before assuming we can close the
windows.

I did a local test with 100 wpt run:

  • without fix: 16/100 failures.
  • with fix: 0/100 failures.

Bug:1175099,1198255
Change-Id: I70a56ba4821d46d12f45c38d8850c876c5957649

Reviewed-on: https://chromium-review.googlesource.com/2825904
WPT-Export-Revision: 862a5ef5f8bc31b181c7e7b89bff0e998812777c

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 13 subtests

Status Summary

Firefox

OK : 1
PASS: 12
FAIL: 1

Chrome

OK : 1
PASS: 12
FAIL: 1

Safari

OK : 1
PASS: 12
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/cross-origin-embedder-policy/credentialless/cors-or-credentialless/fetch.tentative.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
fetch cross-origin + no-cors + credentials:include: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/html/cross-origin-embedder-policy/credentialless/cors-or-credentialless/fetch.tentative.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK) linked bug:Bug 1693957

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cbd9801fb01a
[wpt PR 28503] - [Credentialless]: Make fetch.tentative.https.html more reliable., a=testonly

https://hg.mozilla.org/mozilla-central/rev/cbd9801fb01a

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.