170537 - [Moz] Cannot set "Imported IE Favorites" to default personal toolbar folder

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Håkan Waara]

Using Phoenix 0.1 (it's just my qualified guess that Mozilla and Phoenix share
the bookmarks code):

Steps to reproduce:
1. Open the "Manage Bookmarks" window.
2. Select the "Imported IE Favorites" folder, or any of its subitems.
3. Try to make any of these your default "Personal Toolbar" folder.

Expected result: The bookmarks should be sharable over the browser boundaries.

Actual result: The favorites do not appear on my personal toolbar.

Comment 1

[Chris Lyon]

WFM - Mozilla 2002092304 on WinXP.

I ran into the same thing using Phoenix 0.1

->Phoenix

Comment 2

[Blake Ross]

-> default owner.

Comment 3

[Pierre Chanial]

-> 0.2

Comment 4

[Pierre Chanial]

that's the whole "set as personal toolbar folder' feature that does not work.
-> fixed.
I guess that it's still impossible to set the imported IE folder as the ptf
because of the id conflict between them. But there would be the same pb in mozilla.
Anyway, when the root bookmark folder will be accessible, the same id conflict
will appear and I will have to clean the way how the personal toolbar folder is
handled (btw: it's currently a mess: ptf is defined by an id and a specific arc...)

Comment 5

[Håkan Waara]

Why are you closing this bug, if it is still impossible to set the imported IE
favorites as "ptf"?  I don't get it, sorry.

Reopening.

Comment 6

[Asa Dotzler [:asa]]

pch, if this is something you're not going to fix (setting IE favorites,
specifically, as default bookmark toolbar folder) then feel free mark it
won'tfix. I'll be happy to verify.  

Comment 7

[Pierre Chanial]

I will fix that when I will clean the way how the ptf is managed, but this is a
seamonkey issue and we will have to fork the cpp bookmark files.
Hwaara: I marked this bug as fixed because I checked in the phoenix part of the
bug, ie set as ptf doesn't work at all and was asking asa for QA.

The "imported favorite folder" id is 'NC:SystemBookmarksStaticRoot' and should
not. It should be a regular folder.

Comment 8

[Asa Dotzler [:asa]]

Pierre, I can verify that the setting of ptf works where it didn't before (I did
notice that if I set it to several different folders in the same manager
bookmarks session that some of the previously selected folder items aren't
cleared until a restart of the browser).

Comment 9

[Håkan Waara]

So this is fixed for Phoenix, but not Mozilla-the-browser now? If that's true-
that sure is good enough for me! :-)

Comment 10

[Pierre Chanial]

hakan: before the fix I checked in, it was not possible to set any folder as ptf
in phoenix. Now the situation is the same in phoenix and moz: you can set any
folder as ptf except the root folder and the ie imported folder.

Comment 11

[José Jeria]

Is this Phoenix only? Same in Mozilla, see bug 139136.

Comment 12

[Asa Dotzler [:asa]]

Pierre, is there a plan to make imported IE favorites into real bookmarks in
real folders so they behave the same as mozilla bookmarks?

Comment 13

[Blake Ross]

We have to do something either.  Either disable the menuitem for the IE folder
or (preferably) just make it work properly.

Comment 14

[Mike Connor [:mconnor]]

taking QA contact, sorry about the bugspam

Comment 15

[Pierre Chanial]

fixed.

Comment 16

[Simon Paquet [:sipaq]]

verified fixed 2003-11-09

Comment 17

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change