Closed Bug 1705377 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 28506 - [ResourceTiming] Prefer PerformanceObserver over getEntriesByType in WPTs

Categories

(Core :: Performance, task, P4)

Product:
Core
Component:
Performance
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28506 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28506
Details from upstream follow.

b'Tom McKee <tommckee@chromium.org>' wrote:

[ResourceTiming] Prefer PerformanceObserver over getEntriesByType in WPTs

Older versions of the Resource Timing spec don't specify a strong enough
ordering constraint between an element's "onload" and the
PerformanceResourceTiming entry being added to the Performance Timeline.
As such, our strategy of calling "performance.getEntriesByType()" after
the "onload" event fires isn't guaranteed to return the expected entry.

This CL modifies our approach to use, and block on, a
PerformanceObserver being notified of entries being added to the
timeline. This eliminates a class of flakiness we were seeing during
manual testing.

Bug: 1171767
Change-Id: Ifa4995683f5ef4ff6e53f9780f6d485e6cfb3d81
GithubIssue: https://github.com/w3c/resource-timing/issues/254

Reviewed-on: https://chromium-review.googlesource.com/2826597
WPT-Export-Revision: 4b8aada1b3a5293b026f2547f943a820f1229d4d

Component: web-platform-tests → Performance
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 1 subtests

Status Summary

Firefox

OK : 5[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 6[GitHub]
PASS : 11[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 12[GitHub]
FAIL : 1

Chrome

OK : 6
PASS : 12
FAIL : 1

Safari

OK : 3
PASS : 6
FAIL : 2
TIMEOUT: 6
NOTRUN : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/resource-timing/tao-star-SO-XO-SO-redirect-chain.https.html
Verify that cross origin resources' timings are exposed when cross-origin redirects have Timing-Allow-Origin: * headers: FAIL (Chrome: PASS, Safari: TIMEOUT)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/75d42ecd9907
[wpt PR 28506] - [ResourceTiming] Prefer PerformanceObserver over getEntriesByType in WPTs, a=testonly

https://hg.mozilla.org/mozilla-central/rev/75d42ecd9907

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.