1705386 - The text from the "Set Firefox as your default browser" wraps on a second row

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect)

Description

[Rares Doghi, Desktop QA]

Attachment: 2021-04-15_14h52_41.png

[Affected platforms]:
Platforms: Windows 10

[Steps to reproduce]

1. Launch the Firefox browser with a fresh profile.
2. Close and start Firefox again with the same profile.

[Expected result]
The text from the "Set Firefox as your default browser" modal should not wrap on a second row.

[Actual result]
The text from the "Set Firefox as your default browser" modal wraps on a second row.

Comment 1

[:Gijs (he/him)]

Hm, I thought I knew what was happening here but I actually can't reproduce on last night's nightly.

Can you check what build you're on, and what Windows DPI settings you see this at?

Comment 2

[Rares Doghi, Desktop QA]

I was in the latest Nightly, the build from today, I could only reproduce it on Windows 10 and 7, resolution is 1920 x 1080 with the recommended 100% scaling.

Comment 3

[Rares Doghi, Desktop QA]

This is the build id: 20210414160838

Comment 4

[:Gijs (he/him)]

(In reply to Rares Doghi from comment #2)

I was in the latest Nightly, the build from today, I could only reproduce it on Windows 10 and 7, resolution is 1920 x 1080 with the recommended 100% scaling.

Thanks for the super quick response.

This is gonna be funnn, rounding errors! I can repro with 100% scaling, but not with 150% (the default for my machine). Investigating further...

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1705386 - set the correct width on dialogs across scaling, r?mconley,jaws

As @jfkthame pointed out on matrix, 'ch' units are based on the
rendering of the '0' character, and thus their width in CSS 'px'
can vary for fonts that line things up to device pixels, which
can cause pretty big variations if you start multiplying with
large numbers like the dialog width. As a result, the dialog
was 30 CSS pixels narrower at 100dpi than at 150dpi, which
caused the wrapping.

I also noticed we forgot to update the width for checkboxes
and text in dialogs after our font-size changes in bug 1701920,
so I took the opportunity of fixing that here.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea0c0f99c53d
set the correct width on dialogs across scaling, r=jaws

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ea0c0f99c53d

Comment 8

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Nightly build 89.0a1 (2021-04-16).