1705443 - Permanent failure line even for successful builds: ERROR - check> Traceback (most recent call last):

Status: RESOLVED FIXED

(Core :: Performance, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This started with the changes from bug 1697585. Successful builds contain a line picked up as failure line (switch to 'Failure Summary') tab at the bottom: https://treeherder.mozilla.org/jobs?repo=autoland&revision=0ce8cafaccaf1ffe8daba0460f0b523454179a1f&selectedTaskRun=P_1yE6JgSEGxEzOrR7S1ZQ.0

[task 2021-04-14T22:09:19.875Z] 22:09:19     INFO -  check> TEST-PASS | check_vanilla_allocations.py | ok
[task 2021-04-14T22:09:19.875Z] 22:09:19     INFO -  check> make[4]: Leaving directory '/builds/worker/workspace/obj-build/js/src/build'
[task 2021-04-14T22:09:37.593Z] 22:09:37     INFO -  check> make[4]: Entering directory '/builds/worker/workspace/obj-build/ipc/ipdl/test/ipdl'
[task 2021-04-14T22:09:37.594Z] 22:09:37     INFO -  check> ...............................................................................................................................F.......................
[task 2021-04-14T22:09:37.594Z] 22:09:37     INFO -  check> ======================================================================
[task 2021-04-14T22:09:37.594Z] 22:09:37     INFO -  check> FAIL: test (__main__.ErrorTestCase)
[task 2021-04-14T22:09:37.594Z] 22:09:37     INFO -  check> ErrorTestCase test of "/builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/error/PIntrPriority.ipdl"
[task 2021-04-14T22:09:37.594Z] 22:09:37     INFO -  check> ----------------------------------------------------------------------
[task 2021-04-14T22:09:37.595Z] 22:09:37    ERROR -  check> Traceback (most recent call last):
[task 2021-04-14T22:09:37.595Z] 22:09:37     INFO -  check>   File "/builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/runtests.py", line 16, in test
[task 2021-04-14T22:09:37.595Z] 22:09:37     INFO -  check>     self.checkPassed()
[task 2021-04-14T22:09:37.595Z] 22:09:37     INFO -  check>   File "/builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/runtests.py", line 82, in checkPassed
[task 2021-04-14T22:09:37.595Z] 22:09:37     INFO -  check>     self.mkCustomMsg('Did not see expected error "' + e + '"'),
[task 2021-04-14T22:09:37.595Z] 22:09:37     INFO -  check> AssertionError: False is not true :
[task 2021-04-14T22:09:37.596Z] 22:09:37     INFO -  check> ### Command: /builds/worker/workspace/obj-build/_virtualenvs/init_py3/bin/python /builds/worker/checkouts/gecko/ipc/ipdl/ipdl.py --sync-msg-list=/builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/sync-messages.ini --msg-metadata=/builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/message-metadata.ini -I /builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/error/extra -I /builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/error -d /tmp/ipdl_unit_test_sa7mlh3 /builds/worker/checkouts/gecko/ipc/ipdl/test/ipdl/error/PIntrPriority.ipdl
[task 2021-04-14T22:09:37.596Z] 22:09:37     INFO -  check> ### Did not see expected error "error: intr message `Msg' cannot specify [Priority]"
[task 2021-04-14T22:09:37.596Z] 22:09:37     INFO -  check> ### stderr:
[task 2021-04-14T22:09:37.596Z] 22:09:37    ERROR -  check> Traceback (most recent call last):
[task 2021-04-14T22:09:37.596Z] 22:09:37     INFO -  check>   File "/builds/worker/checkouts/gecko/ipc/ipdl/ipdl.py", line 151, in <module>
[task 2021-04-14T22:09:37.597Z] 22:09:37     INFO -  check>     if not ipdl.typecheck(ast):
[task 2021-04-14T22:09:37.597Z] 22:09:37     INFO -  check>   File "/builds/worker/checkouts/gecko/ipc/ipdl/ipdl/__init__.py", line 54, in typecheck
[task 2021-04-14T22:09:37.597Z] 22:09:37     INFO -  check>     return TypeCheck().check(ast, errout)
[task 2021-04-14T22:09:37.597Z] 22:09:37     INFO -  check>   File "/builds/worker/checkouts/gecko/ipc/ipdl/ipdl/type.py", line 800, in check
[task 2021-04-14T22:09:37.597Z] 22:09:37     INFO -  check>     if not runpass(GatherDecls(builtinUsing, self.errors)):
[task 2021-04-14T22:09:37.597Z] 22:09:37     INFO -  check>   File "/builds/worker/checkouts/gecko/ipc/ipdl/ipdl/type.py", line 792, in runpass
[task 2021-04-14T22:09:37.598Z] 22:09:37     INFO -  check>     tu.accept(tcheckpass)
[task 2021-04-14T22:09:37.598Z] 22:09:37     INFO -  check>   File "/builds/worker/checkouts/gecko/ipc/ipdl/ipdl/ast.py", line 128, in accept
[task 2021-04-14T22:09:37.598Z] 22:09:37     INFO -  check>     return visit(self)
[task 2021-04-14T22:09:37.598Z] 22:09:37     INFO -  check>   File "/builds/worker/checkouts/gecko/ipc/ipdl/ipdl/type.py", line 993, in visitTranslationUnit
[task 2021-04-14T22:09:37.598Z] 22:09:37     INFO -  check>     p.accept(self)
[task 2021-04-14T22:09:37.598Z] 22:09:37     INFO -  check>   File "/builds/worker/checkouts/gecko/ipc/ipdl/ipdl/ast.py", line 128, in accept
[task 2021-04-14T22:09:37.599Z] 22:09:37     INFO -  check>     return visit(self)
[task 2021-04-14T22:09:37.599Z] 22:09:37     INFO -  check>   File "/builds/worker/checkouts/gecko/ipc/ipdl/ipdl/type.py", line 1169, in visitProtocol
[task 2021-04-14T22:09:37.599Z] 22:09:37     INFO -  check>     msg.accept(self)
[task 2021-04-14T22:09:37.599Z] 22:09:37     INFO -  check>   File "/builds/worker/checkouts/gecko/ipc/ipdl/ipdl/ast.py", line 128, in accept
[task 2021-04-14T22:09:37.599Z] 22:09:37     INFO -  check>     return visit(self)
[task 2021-04-14T22:09:37.599Z] 22:09:37     INFO -  check>   File "/builds/worker/checkouts/gecko/ipc/ipdl/ipdl/type.py", line 1291, in visitMessageDecl
[task 2021-04-14T22:09:37.599Z] 22:09:37     INFO -  check>     md.priority(),
[task 2021-04-14T22:09:37.600Z] 22:09:37     INFO -  check>   File "/builds/worker/checkouts/gecko/ipc/ipdl/ipdl/ast.py", line 354, in priority
[task 2021-04-14T22:09:37.600Z] 22:09:37     INFO -  check>     }[self.attributes["Priority"].value]
[task 2021-04-14T22:09:37.600Z] 22:09:37     INFO -  check> KeyError: 'high'

Comment 1

[Sean Feng [:sefeng]]

Attachment: Bug 1705443 - Use vsync priority in PIntrPriority::Msg r=smaug

We've renamed the high priority to vsync in bug 1697585,
this is just adapting the change.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1271c319a2a1
Use vsync priority in PIntrPriority::Msg r=smaug

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1271c319a2a1