1705454 - [Meta] Use the old Photon icons instead of the Proton ones

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

This bug is to replace the new Proton icons with the old Photon icons.

The Proton icons 1px wide lines and our icon use the 2px lines. Combining both looks weird.

Also do we think that the old icons look clearer and less abstract.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1705454 - Override the first batch of Proton icons. r=aleca

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: Screenshot from 2021-04-15 11-24-49.png

The indicator-private-browsing.svg seems to be gone.

Comment 3

[Richard Marti (:Paenglab)]

(In reply to Alessandro Castellani [:aleca] from comment #2)

Created attachment 9216175 [details]
Screenshot from 2021-04-15 11-24-49.png

The indicator-private-browsing.svg seems to be gone.

This seems to be a regression from bug 1683865.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d8853ed5a46e
Override the first batch of Proton icons. r=aleca

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Bug 1705454 - Override the next batch of Proton icons. r=aleca

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/49bdda1e1ac1
Override the next batch of Proton icons. r=aleca

Comment 7

[Richard Marti (:Paenglab)]

Attachment: Bug 1705454 - Third batch of verriding of Proton icons. r=aleca

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/116dbf638b91
Third batch of verriding of Proton icons. r=aleca

Comment 9

[Alessandro Castellani [:aleca]]

There's a small typo in the commit message of the last pushed patch.
Should we back it out and push it back with a fix?

Comment 10

[Rob Lemley [:rjl]]

I saw that 😉 I don't have a strong opinion either way. It's a commit message, so it's not going to break anything or confuse users. I would even argue that a backout draws more attention to the typo.

(In reply to Alessandro Castellani [:aleca] from comment #9)

There's a small typo in the commit message of the last pushed patch.
Should we back it out and push it back with a fix?

Comment 11

[Richard Marti (:Paenglab)]

Attachment: Bug 1705454 - Override the category icons in Add-ons manager introduced in bug 1706935. r=aleca

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/23162efea734
Override the category icons in Add-ons manager introduced in bug 1706935. r=aleca

Comment 13

[Richard Marti (:Paenglab)]

Attachment: Bug 1705454 - Override the extensionGeneric.scg icon introduced in bug 1708788. r=aleca

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/87b0d1f6d339
Override the extensionGeneric.scg icon introduced in bug 1708788. r=aleca

Comment 15

[Richard Marti (:Paenglab)]

Attachment: Bug 1705454 - Override the last two Add-on Manager icons with the Photon versions. r=aleca

Comment 16

[Richard Marti (:Paenglab)]

I think we can close this bug. If they will find icons to change I can file new bugs.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e2d961ae14e5
Override the last two Add-on Manager icons with the Photon versions. r=aleca