Closed Bug 1705507 Opened 3 years ago Closed 3 years ago

Fix search bar panel colors for Proton

Categories

(Firefox :: Search, task, P2)

task
Points:
2

Tracking

()

RESOLVED FIXED
89 Branch
Iteration:
89.2 - Apr 5 - Apr 18
Tracking Status
firefox89 --- fixed

People

(Reporter: adw, Assigned: adw)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

There isn't a Proton spec for the search bar panel, but based on discussion in D111751, it should use the same colors as the urlbar panel for item/search-button hover and selection. Currently the selection color is correct, but the hover color is --arrowpanel-dimmed, which doesn't match the urlbar. The hover color is the only thing that needs updating AFAICT.

There's a big WIP patch in bug 1697092 that updates all autocomplete popup colors, but Harry says it's blocked on a major issue and doesn't have a clear path toward landing, so we should probably ignore it here.

See Also: → 1702772

Another agreed-on change from the discussion in D111751 is to make the settings button label left/start-aligned instead of centered so that it matches the look of menu items in the app menu, etc.

Depends on D111751

Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9038aab9aba8
Fix search bar panel colors for Proton. r=harry,desktop-theme-reviewers
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: