Closed Bug 1705526 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 28526 - Always add consumed block-size when calculating legacy static pos.

Categories

(Core :: Layout: Columns, task, P4)

task

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28526 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28526
Details from upstream follow.

b'Morten Stenshorne <mstensho@chromium.org>' wrote:

Always add consumed block-size when calculating legacy static pos.

We used to do it only when the parent of an OOF was a fragmentainer, but
this is always needed for any descendant as well. The legacy code in
LayoutBox::ComputeInlineStaticDistance() expects the block-offset to be
relative to the parent in the flow thread coordinate space.

Also initialize previous_break_token_ to nullptr. This was a mistake
during oilpan conversion, which suddenly became a problem (it may have
been safe-ish before, but not anymore).

The new test abspos-autopos-contained-by-viewport-001.html would fail
without this fix.

Bug: 1199258
Change-Id: I7520cad9112485e908df3be33b354aec58332db8

Reviewed-on: https://chromium-review.googlesource.com/2826460
WPT-Export-Revision: 5e59c325e05316e51e7f7f8e2175fc6b9a195ea8

Component: web-platform-tests → Layout: Columns
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

PASS: 2

Safari

FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3aa2e813a4e3
[wpt PR 28526] - Always add consumed block-size when calculating legacy static pos., a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.