Closed Bug 1705565 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 28528 - Revert "Expand synthesized clip layer by 1 pixel"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox90 fixed)

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28528 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28528
Details from upstream follow.

b'Xianzhu Wang <wangxianzhu@chromium.org>' wrote:

Revert "Expand synthesized clip layer by 1 pixel"

This reverts commit 8643a99de2538ac309252247a5fe90756d9014e9.

Reason for revert: Caused crbug.com/1199366. The underlying issue is
still unclear yet. Revert first, and we'll continue to investigate
which will be tracked by crbug.com/1171601.

Original change's description:

Expand synthesized clip layer by 1 pixel

Though the clip mask layer and the masked layer are perfectly aligned in
blink and cc, the geometry of the quads may go through different mapping
code paths, depending on the types of the quads, causing slight
misalignment of the mask quad and masked quad and hairline align the
edges. Expand the mask layer by 1 pixel to ensure its coverage on the
masked layer in case of floating-point errors etc.

Bug: 1171601
Change-Id: I4b64e1b6147d4e003a1ad131a605ee4b9886d57f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2786129
Commit-Queue: Xianzhu Wang \<wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers \<pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869019}

Bug: 1171601,1199366
Change-Id: Ibd2c8206c28e494290b42f0c46cee86e277942a5
Reviewed-on: https://chromium-review.googlesource.com/2828563
WPT-Export-Revision: 0ef11813976e5dff101468538c3ffd5ab5585584

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eb555499a658
[wpt PR 28528] - Revert "Expand synthesized clip layer by 1 pixel", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.