1705598 - Get rid of `WSRunScanner::mHTMLEditor` because of unused

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P3)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1705598 - part 1: Get rid of `WSRunScanner::mHTMLEditor` r=m_kato!

It's not referred by anybody.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1705598 - part 2: Make the constructor of `WSRunScanner` take editing host instead of `HTMLEditor` r=m_kato!

I think that it's no matter to make WSRunScanner work without editing host.
Therefore, this patch make it take pointer of Element rather than reference.

Depends on D112502

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1705598 - part 3: Make `WSRunScanner::GetPreviousEditableCharPoint()` and `WSRunScanner::GetInclusiveNextEditableCharPoint()` take editing host instead of `HTMLEditor` r=m_kato!

Depends on D112503

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1705598 - part 4: Make `WSRunScanner::ScanNextVisibleNodeOrBlockBoundary()` and `WSRunScanner::ScanPreviousVisibleNodeOrBlockBoundary()` take editing host instead of `HTMLEditor` r=m_kato!

Depends on D112504

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1705598 - part 5: Make `WSRunScanner::GetRangeInTextNodesToForwardDeleteFrom()` and `WSRunScanner::GetRangeInTextNodesToBackspaceFrom()` take editing host instead of `HTMLEditor` r=m_kato!

Depends on D112505

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1705598 - part 6: Make `WSRunScanner::GetRangesForDeletingAtomicContent()` take editing host instead of `HTMLEditor` r=m_kato!

Depends on D112506

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1705598 - part 7: Make `WSRunScanner::GetRangeContainingInvisibleWhiteSpacesAtRangeBoundaries()` take editing host instead of `HTMLEditor` r=m_kato!

Depends on D112507

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1705598 - part 8: Make `WSRunScanner::AutoInclusiveAncestorBlockElementsJoiner()` take editing host instead of `HTMLEditor` r=m_kato!

Depends on D112508

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f8394b8bc13
part 1: Get rid of `WSRunScanner::mHTMLEditor` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/16465ad721a6
part 2: Make the constructor of `WSRunScanner` take editing host instead of `HTMLEditor` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/643e94d61394
part 3: Make `WSRunScanner::GetPreviousEditableCharPoint()` and `WSRunScanner::GetInclusiveNextEditableCharPoint()` take editing host instead of `HTMLEditor` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/296ffa58e3dc
part 4: Make `WSRunScanner::ScanNextVisibleNodeOrBlockBoundary()` and `WSRunScanner::ScanPreviousVisibleNodeOrBlockBoundary()` take editing host instead of `HTMLEditor` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/14d4774d13b1
part 5: Make `WSRunScanner::GetRangeInTextNodesToForwardDeleteFrom()` and `WSRunScanner::GetRangeInTextNodesToBackspaceFrom()` take editing host instead of `HTMLEditor` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/fd494b2c2e05
part 6: Make `WSRunScanner::GetRangesForDeletingAtomicContent()` take editing host instead of `HTMLEditor` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/bc23fb1f772f
part 7: Make `WSRunScanner::GetRangeContainingInvisibleWhiteSpacesAtRangeBoundaries()` take editing host instead of `HTMLEditor` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/cc7a0bbb64fb
part 8: Make `WSRunScanner::AutoInclusiveAncestorBlockElementsJoiner()` take editing host instead of `HTMLEditor` r=m_kato

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/4f8394b8bc13
https://hg.mozilla.org/mozilla-central/rev/16465ad721a6
https://hg.mozilla.org/mozilla-central/rev/643e94d61394
https://hg.mozilla.org/mozilla-central/rev/296ffa58e3dc
https://hg.mozilla.org/mozilla-central/rev/14d4774d13b1
https://hg.mozilla.org/mozilla-central/rev/fd494b2c2e05
https://hg.mozilla.org/mozilla-central/rev/bc23fb1f772f
https://hg.mozilla.org/mozilla-central/rev/cc7a0bbb64fb