1705697 - WebConsole can end up broken when navigating between pages that would create warning groups

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[kernp25]

Attachment: firefox_N2hHSwaCPk.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

1. Install https://addons.mozilla.org/firefox/addon/docx-viewer/
2. Open a new tab
3. Make sure devtools.webconsole.persistlog is true
4. Open the developer console (https://developer.mozilla.org/en-US/docs/Tools/Web_Console)
5. Open https://calibre-ebook.com/downloads/demos/demo.docx

Actual results:

It will stop logging the Navigated to... in the console.

After some more browsing the console gets broken (see picture).

Expected results:

Should just work as expected.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Console' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[kernp25]

The toolbar is removed in the attached picture.

Comment 3

[kernp25]

Attachment: firefox_JxgFba6UqQ.png

How it should look like.

Comment 4

[kernp25]

Attachment: demo.docx

Comment 5

[kernp25]

Update: You need to open this link to reproduce the bug.

Comment 6

[kernp25]

Update 2: You need to open google and search for filetype:docx test.
Then click on any link that points to a docx file.

Comment 7

[kernp25]

Attachment: aCKO7Kgr4a.mp4

How to reproduce the bug.

Comment 8

[kernp25]

Attachment: SswzPiSXuN.mp4

In this video the toolbar will only be removed but the logging will continue working.

Comment 9

[kernp25]

(In reply to kernp25 from comment #8)

Created attachment 9216416 [details]
SswzPiSXuN.mp4

In this video the toolbar will only be removed but the logging will continue working.

This happens also with devtools.webconsole.persistlog set to false.

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

Hello kernps25, thanks for the report.

Could you paste the content of the browser console here (https://developer.mozilla.org/en-US/docs/Tools/Browser_Console) ? that might help

Comment 11

[kernp25]

Attachment: Error: Descriptor already destroyed for target: Target:server0.conn7.child53/webExtensionTarget1 get descriptorFront resource://devtools/client/fronts/targets/target-mixin.js:101 get localTab resource://devtools/client/fronts/targets/target-mixin.

(In reply to kernp25 from comment #8)
> Created attachment 9216416 [details]
> SswzPiSXuN.mp4
> 
> In this video the toolbar will only be removed but the logging will continue working.

The browser console content:

``

Comment 12

[kernp25]

Attachment: firefox_qf8sI7UuAN.png

For the toolbar removed only bug (this bug seems to happen, if the page is still loading and then navigated back).

Comment 13

[kernp25]

Attachment: firefox_ezw97W4StK.png

The browser console content for the bug i reported first.

Comment 14

[Nicolas Chevobbe [:nchevobbe]]

I was able to reproduce on 87 once, but I was able to get the new message once I did evaluated an expression in the console.
I wasn't able to reproduce on Firefox 89, and I know we did some changes around those areas.
Would you be able to check on Firefox Nightly if you still see the issue?

Comment 15

[kernp25]

Attachment: firefox_G2XmTT9sKB.png

On Firefox Nightly (89.0a1 (2021-04-16) (64-Bit)) it will show TypeError: can't access property "push", state.warningGroupsById.get(...) is undefined in the browser console.

STR for the stop logging bug:

1. Open a new tab
2. Make sure devtools.webconsole.persistlog is true
3. Open the web console (https://developer.mozilla.org/en-US/docs/Tools/Web_Console)
4. Open google and search for filetype:docx test
5. Click on a link that points to a docx file

Comment 16

[kernp25]

The bug with the toolbar being removed seems fixed in Firefox Nightly.

Comment 17

[Nicolas Chevobbe [:nchevobbe]]

Looks like there's a race condition that can be triggered where a warning group message could be "repeated" with a warning message from a previous navigation, which would make the new one being ignored and causing issues further down the road.
I'll work on a proper patch and test for this on Monday (the issue is probably here since we introduced warning groups)

Comment 18

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1705697 - [devtools] Warning group messages shouldn't be repeatable. r=bomsy.

It could happen that 2 warning group messages could be added successively, before
the navigation message was emitted.
In the reducer, the second message would be seen the same as the first one, and
we'd try to increment the repeat count for the first one.
Unfortunately, the code was expecting a warning group to be created, and there
was an exception thrown as we couldn't retrieve it.
This is fixed by not allowing warning groups to be repeated.
A mocha test is added instead of a mochitest, as the issue would have been tricky
to trigger properly.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e74900b7d41
[devtools] Warning group messages shouldn't be repeatable. r=bomsy.

Comment 20

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/7e74900b7d41

Comment 21

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9218227 [details]
Bug 1705697 - [devtools] Warning group messages shouldn't be repeatable. r=bomsy.

Beta/Release Uplift Approval Request

• User impact if declined: The WebConsole can end up in a broken state, not showing any messages that are emitted from the page, which could be very confusing for the user
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): the patch is a one line fix, where we change the "configuration" of a given type of message so it can't be "repeated" in the console UI
• String changes made/needed:

Comment 22

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9218227 [details]
Bug 1705697 - [devtools] Warning group messages shouldn't be repeatable. r=bomsy.

Low risk one liner with tests, approved for 89 beta 9, thanks.

Comment 23

[Pascal Chevrel (relman team) -> :pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/dc8f5458731b