1705721 - unable to unmute mic after muting from global mute toggle when using a tiling window manager

Status: NEW

(Firefox :: Site Permissions, defect, P3)

Description

[Diabolic Preacher]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

1. set nightly option WebRTC Global Mute Toggles to on.
2. get on a webrtc call. i experienced with google duo
3. excuse yourself from call and mute your mic from global mute toggle icon
4. try to unmute by clicking on the muted icon (mic with strikethrough)
5. unable to unmute and find no other icon to unmute the mic.

Actual results:

other party waited for several minutes and dropped the call after not getting any response from me as i remained unable to unmute.

Expected results:

mic should have unmuted,

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::WebRTC: Audio/Video' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Paul Adenot (:padenot)]

Is this a known regression? It worked OK last I checked.

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

try to unmute by clicking on the muted icon (mic with strikethrough)

Hi, which icon do you mean here? Are you unmuting by clicking on the same global mute toggle icon you muted with?

Comment 4

[Diabolic Preacher]

(In reply to Jan-Ivar Bruaroey [:jib] (needinfo? me) from comment #3)

try to unmute by clicking on the muted icon (mic with strikethrough)

Hi, which icon do you mean here? Are you unmuting by clicking on the same global mute toggle icon you muted with?

Yes Jan, I assumed it is a toggle so I clicked on the same global mute togg=
le icon that I muted with

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Yes Jan, I assumed it is a toggle so I clicked on the same global mute toggle icon that I muted with

Thanks, and sorry for the delay in following up. Unfortunately, I am not able to reproduce (though I'm on mac and not linux).

Does the mute button change appearance back and forth at least when you toggle it between mute and unmute? I.e. is the problem only that audio does not resume? Does it reproduce locally with https://jsfiddle.net/jib1/yxbLvjm6/show (you may wish to use headphones to avoid feedback)?

Comment 6

[Diabolic Preacher]

Hi Jan,

I think I found the actual issue with the icon.

1. The button to toggle the mic muting in the global toggle bar gets activates when the pointer is halfway up the top border of the button and it only activates the button for a very tiny portion of the area, hard to get it right.
2. what makes things easy when muting the mic is that a rounded square gets highlighted around the mic, indicating that i put my cursor correctly and now if i click, mic will get muted. No indication of this sort is given when trying to unmute the mic. The button is dark and depressed.

My two suggestions would be to

1. increase the area and bring it closer to the area of the mic mute button.
2. give some visual feedback that the button is pointed on correctly when trying to unmute.

i don't have proper screenshot tools, but i would share a pic of the button being highlighted. unfortunately the cursor was not captured.

i don't see an option to attach a file below this comment.

Comment 7

[Diabolic Preacher]

Attachment: global mute toggle with mute button area highlighted

Jan,

i added a little black dot on top left of the icon square to show the place where the mouse pointer had to be, with half of the pointer (regular size) off the top edge of that square.

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Thanks Preacher for identifying that as the problem! This sounds like a front-end issue. Mike do you know whom to assign this to?

Comment 9

[Emma Zühlcke [:emz]]

I can't reproduce on Linux with Gnome desktop. I can mute / unmute using the whole button surface. The hover effect also works correctly.
Are you using a tiling window manager (looks like it from the screenshot)? If so, could you test if you can reproduce the issue with a different (non-tiling) window manager?

Comment 10

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

I agree that we need to know more about this user's Linux distribution / environment. I'm unable to reproduce the hover behaviour being described in comment 6 with stock Ubuntu.

Comment 11

[Diabolic Preacher]

I am using i3wm which is a tiling window manager on openSUSE Tumbleweed. I have icewm that comes default with minimal gui install of openSUSE but i3 is my daily driver and comfort zone of sorts. I am sure something can be found to work for floating windows in tiling window managers. I will not be able to help with non tiling window manager options, apart from icewm, because

1. i will need to clean up manually a lot of the leftovers of the big DE's like gnome,etc.
2. even if it did work in icewm, i can't easily change my workflow to that.
   if it is possible to help in some other way, i will post here, but for now, please consider tiling window manager as a valid use case.

Comment 12

[Daniel Bodea [:danibodea]]

I have attempted reproducing this issue on Ubuntu 20 with i3 Windows Manager installed.(https://kifarunix.com/install-and-setup-i3-windows-manager-on-ubuntu-20-04/)
Fortunately, I managed to reproduce it in the Nightly v90.0a1 and Beta v89.0b4-v89.0b14, but it would not reproduce in the same in Firefox Release v88.0.1, so it is a regression.

It does not reproduce in Ubuntu with default Windows Manager, only with i3 Windows Manaager, where the new Global Sharing Overlay UI is improperly displayed.

Comment 13

[Emma Zühlcke [:emz]]

(In reply to Bodea Daniel [:danibodea] from comment #12)

I have attempted reproducing this issue on Ubuntu 20 with i3 Windows Manager installed.(https://kifarunix.com/install-and-setup-i3-windows-manager-on-ubuntu-20-04/)
Fortunately, I managed to reproduce it in the Nightly v90.0a1 and Beta v89.0b4-v89.0b14, but it would not reproduce in the same in Firefox Release v88.0.1, so it is a regression.

It does not reproduce in Ubuntu with default Windows Manager, only with i3 Windows Manaager, where the new Global Sharing Overlay UI is improperly displayed.

Thanks for confirming! Since you already have the setup, could you run mozregression with i3 so we can find the regressing bug?

Setting this to P3 for now since mute toggles are an experimental feature.

Comment 14

[Daniel Bodea [:danibodea]]

I'll do my best to investigate it:

Firstly, I have to say that the UI of the Mute Toggles / Global Sharing Indicator is also broken in Release v88.0 and v88.0.1; the little GSO window shows extra padding under it, but the original issue does not occur; When the user clicks the mute microphone button, the buttons do not move down and switch places with the incorrectly displayed padding, like in an affected build, but remains in place so hovering and clicking the buttons is still done without issues.

Secondly, I need to mention that even in the affected builds, the buttons can still be clicked, but the UI is just incorrectly shown. The actual buttons can still be pressed in their original position they had before they fell down and switched places with the incorrectly displayed padding.

I other words, the issue that should have originally been logged is the presence of the incorrect padding that messes things up after the first button press, more in Nightly v90.0a1 than in Release v88.0.1. Instead, it addressed the fact that the buttons are dropping, and clicking them gets confusing.

Unfortunately, while testing older nightly builds it appears that the older versions are still affected by the original bug, where the UI drops down from their intended position, making hovering them and clicking them complicated and only the release channel shows this different behavior.

This being said, I will remove the regression keyword, because it appears to be an implementation issue.

Comment 15

[Emma Zühlcke [:emz]]

Thanks!