Remove analytics code from screenshots
Categories
(Firefox :: Screenshots, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox100 | --- | fixed |
People
(Reporter: emmamalysz, Assigned: bubuanabelas)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
+++ This bug was initially created as a clone of Bug #1705744 +++
Analytics code (such as analytics.js) is no longer used for screenshots and can be removed.
Please ensure screenshots still work when submitting a patch
Reporter | ||
Updated•3 years ago
|
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Reporter | ||
Comment 2•3 years ago
|
||
Going to unassign this bug as there has not been activity for a few months
Reporter | ||
Updated•3 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
Could I be assigned to this bug? I've seen the changes needed on the previously submited patch and looked at bug 1724081 so I understand what has to be done.
Comment 4•2 years ago
|
||
(In reply to Joaquín Serna from comment #3)
Could I be assigned to this bug? I've seen the changes needed on the previously submited patch and looked at bug 1724081 so I understand what has to be done.
Sure. Do you have your dev environment set up and the ability to (artifact) build firefox?
Assignee | ||
Comment 5•2 years ago
|
||
(In reply to Sam Foster [:sfoster] (he/him) from comment #4)
(In reply to Joaquín Serna from comment #3)
Could I be assigned to this bug? I've seen the changes needed on the previously submited patch and looked at bug 1724081 so I understand what has to be done.
Sure. Do you have your dev environment set up and the ability to (artifact) build firefox?
Yes I do. I've contributed in some other bugs recently.
After seeing this one and bug 1724081 I noticed that a lot of the screenshot's code could be purged so I'd like to do that.
Updated•2 years ago
|
Comment 6•2 years ago
|
||
Please go ahead. I've assigned to you for now. You can flag me (sfoster) for review and I'm happy to answer any questions you run into along the way. We also have a #screenshots matrix channel you can use for questions.
Assignee | ||
Comment 7•2 years ago
|
||
Updated•2 years ago
|
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dd958732a930 Remove analytics code from screenshots r=sfoster
Comment 9•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Updated•2 years ago
|
Description
•