Closed Bug 1705748 Opened 1 year ago Closed 2 months ago

Remove analytics code from screenshots

Categories

(Firefox :: Screenshots, task, P3)

task

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: emmamalysz, Assigned: bubuanabelas)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1705744 +++

Analytics code (such as analytics.js) is no longer used for screenshots and can be removed.

Please ensure screenshots still work when submitting a patch

Summary: Remove analytcs code from screenshots → Remove analytics code from screenshots
Assignee: nobody → falgunimst95
Status: NEW → ASSIGNED
Attachment #9216502 - Attachment description: WIP: Bug 1705748: Remove analytics code from screenshots → Bug 1705748: fix Remove analytics code from screenshots
Attachment #9216502 - Attachment description: Bug 1705748: fix Remove analytics code from screenshots → Bug 1705748: still working to fix Remove analytics code from screenshots
Attachment #9216502 - Attachment description: Bug 1705748: still working to fix Remove analytics code from screenshots → Bug 1705748: fix Remove analytics code from screenshots
Attachment #9216502 - Attachment description: Bug 1705748: fix Remove analytics code from screenshots → Bug 1705748: fix eemove analytics code from screenshots
Attachment #9216502 - Attachment description: Bug 1705748: fix eemove analytics code from screenshots → Bug 1705748: fix remove analytics code from screenshots
Attachment #9216502 - Attachment description: Bug 1705748: fix remove analytics code from screenshots → Bug 1705748: fix remove Analytics code from screenshots
Attachment #9216502 - Attachment description: Bug 1705748: fix remove Analytics code from screenshots → Bug 1705748: fixing remove Analytics code from screenshots
Attachment #9216502 - Attachment description: Bug 1705748: fixing remove Analytics code from screenshots → Bug 1705748: fixing Remove Analytics code from screenshots
Attachment #9216502 - Attachment description: Bug 1705748: fixing Remove Analytics code from screenshots → Bug 1705748: fixing Remove Analytics code From Screenshots
Attachment #9216502 - Attachment description: Bug 1705748: fixing Remove Analytics code From Screenshots → Bug 1705748: fixing Remove Analytics Code From Screenshots
Attachment #9216502 - Attachment description: Bug 1705748: fixing Remove Analytics Code From Screenshots → Bug 1705748: fixing Remove Analytics Code from Screenshots
Attachment #9216502 - Attachment description: Bug 1705748: fixing Remove Analytics Code from Screenshots → Bug 1705748: fixing Remove Analytics code from Screenshots
Attachment #9216502 - Attachment description: Bug 1705748: fixing Remove Analytics code from Screenshots → Bug 1705748: fixing Remove Analytics code From Screenshots
Attachment #9216502 - Attachment description: Bug 1705748: fixing Remove Analytics code From Screenshots → Bug 1705748: fixing Remove Analytics Code From Screenshots
Attachment #9216502 - Attachment description: Bug 1705748: fixing Remove Analytics Code From Screenshots → Bug 1705748: fixing Remove Analytics code From Screenshots
Attachment #9216502 - Attachment description: Bug 1705748: fixing Remove Analytics code From Screenshots → Bug 1705748: fixing Remove Analytics Code From Screenshots
Attachment #9216502 - Attachment description: Bug 1705748: fixing Remove Analytics Code From Screenshots → Bug 1705748: fixing Removing Analytics Code From Screenshots
Attachment #9216502 - Attachment description: Bug 1705748: fixing Removing Analytics Code From Screenshots → Bug 1705748: fixing Removing Analytics Code from Screenshots

Going to unassign this bug as there has not been activity for a few months

Status: ASSIGNED → NEW
Assignee: falgunimst95 → nobody

Could I be assigned to this bug? I've seen the changes needed on the previously submited patch and looked at bug 1724081 so I understand what has to be done.

(In reply to Joaquín Serna from comment #3)

Could I be assigned to this bug? I've seen the changes needed on the previously submited patch and looked at bug 1724081 so I understand what has to be done.

Sure. Do you have your dev environment set up and the ability to (artifact) build firefox?

Flags: needinfo?(bubuanabelas)

(In reply to Sam Foster [:sfoster] (he/him) from comment #4)

(In reply to Joaquín Serna from comment #3)

Could I be assigned to this bug? I've seen the changes needed on the previously submited patch and looked at bug 1724081 so I understand what has to be done.

Sure. Do you have your dev environment set up and the ability to (artifact) build firefox?

Yes I do. I've contributed in some other bugs recently.

After seeing this one and bug 1724081 I noticed that a lot of the screenshot's code could be purged so I'd like to do that.

Flags: needinfo?(bubuanabelas)
Attachment #9216502 - Attachment is obsolete: true

Please go ahead. I've assigned to you for now. You can flag me (sfoster) for review and I'm happy to answer any questions you run into along the way. We also have a #screenshots matrix channel you can use for questions.

Assignee: nobody → bubuanabelas
Status: NEW → ASSIGNED
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dd958732a930
Remove analytics code from screenshots r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
Whiteboard: [outreachy-2021-screenshots]
Attachment #9216502 - Attachment is obsolete: false
You need to log in before you can comment on or make changes to this bug.