Closed Bug 1705757 Opened 22 days ago Closed 21 days ago

[fission] Print this frame is broken

Categories

(Core :: Print Preview, task)

task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(3 files)

Going to https://crisal.io/tmp/iframe-slot.html, then right-clicking on the wikipedia frame and going to This frame > Print frame just shows an infinite spinner in the print preview.

We're hitting this condition.

Assignee: nobody → emilio
Flags: needinfo?(emilio)

This makes it trivial to choose the right BrowserParent to print a
browsing context, by removing the OuterWindowID / FrameLoader
indirections.

We were using the top BrowsingContextGroup id in this case, which is
obviously wrong. Also make the API take a BrowsingContext directly,
rather than passing outerwindowids around.

Depends on D112412

There was none, of course :(

Depends on D112413

Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96126f7ecfc5
Move FrameLoader.print to BrowsingContext.print. r=nika,remote-protocol-reviewers,marionette-reviewers,extension-reviewers,zombie
https://hg.mozilla.org/integration/autoland/rev/b10ba48bdd68
Make printing a single frame choose the right process for the preview frame. r=nika
https://hg.mozilla.org/integration/autoland/rev/214612b57101
Add a test for this. r=nika
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/5c17b68026d8
Restore _doPrint to fix mochitest which replaces it.
You need to log in before you can comment on or make changes to this bug.