Closed Bug 1705784 Opened 9 months ago Closed 9 months ago

[wpt-sync] Sync PR 28549 - [GridNG] Apply alignment if possible within for the initial geometry.

Categories

(Core :: Layout: Grid, task, P4)

task

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28549 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28549
Details from upstream follow.

b'Ian Kilpatrick <ikilpatrick@chromium.org>' wrote:

[GridNG] Apply alignment if possible within for the initial geometry.

From: https://drafts.csswg.org/css-grid-1/#algo-overview

"If both the grid container and all tracks have definite sizes, also
apply align-content to find the final effective size of any gaps
spanned by such items; otherwise ignore the effects of track alignment
in this estimation."

This implements the logic for above by adding a bit to the set if all
our our tracks have fixed sizes, then using ComputeSetGeometry.

The test for this sentence was incorrect, also fixed.

Bug: 1045599
Change-Id: I6bd4ddf8c811b3ac175fe52ece6955eff5ed11bc
Reviewed-on: https://chromium-review.googlesource.com/2698145
WPT-Export-Revision: 5cfc8c45a62fc51cfea465e02c1af732e0f8ef72

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002.html
.grid 1: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/34c89e6bab41
[wpt PR 28549] - [GridNG] Apply alignment if possible within for the initial geometry., a=testonly
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.