Closed Bug 1705792 Opened 5 years ago Closed 2 years ago

Update the WebExtensions theme reference to include new theme colors introduced with Proton

Categories

(WebExtensions :: Themes, task, P3)

task

Tracking

(Not tracked)

RESOLVED MOVED

People

(Reporter: rpl, Unassigned)

References

Details

(Keywords: dev-doc-needed)

As briefly discussed in D112378, along with the Proton changes we are introducing some new theme colors that are not yet documented in the theme reference doc page on MDN and/or explicitly listed in the theme.json JSONSchema (the schema does actually allow to include unknown colors as long as they are valid colors, but there is a chance that it was mainly meant to allow extension authors to use a single theme manifest.json for both Firefox and Chrome, and on Firefox the ones that were chrome-specific would be just not used).

This isn't a blocking issue, but it seems reasonable to document the new available theme colors once we are happy with what we added for Proton and they are going to get to release and stay supported for a while.

One way to track down the newly introduced colors may be to compare the ones listed in the default themes (e.g. the default one) between an older non proton version and the most recent one.

No longer depends on: 1705447
See Also: → 1705447

Thanks, Luca! FYI we're tracking implementation of these updates over on the MDN content repo: https://github.com/mdn/content/issues/4390

See Also: → 1708213
Severity: -- → N/A
Priority: -- → P2

The issue tracking the changes to mdn docs (the one linked as a seealso) has been closed as fixed, but I did notice the browser-compat-data was not, and so while the MDN page does highlight that tab_background_separator and toolbar_field_separator have been both deprecated, the compat table at the bottom of the page is still reporting these properties as supported in Firefox.

I filed https://github.com/mdn/browser-compat-data/issues/22215 to track fixing this inconsistentcy and so I'm closing this bugzilla issue as MOVED.

Status: NEW → RESOLVED
Closed: 2 years ago
Priority: P2 → P3
Resolution: --- → MOVED
You need to log in before you can comment on or make changes to this bug.