1705825 - Update proton new user onboarding background image and caption

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to update new user onboarding flow with feedback from UX review

https://docs.google.com/presentation/d/1nGoANskbHb8i8HLunplrsD8DeybW80vIuo6TrO0TxLI/edit#slide=id.gd0f95b6aef_0_1

Comment 1

[Punam Dahiya [:pdahiya]]

Scope of this bug includes uplift of background image & caption when available from marketing

Comment 2

[Ana Medinac]

The final caption is: "Soraya Osorio — Metal sculptor, Firefox fan"

Comment 3

[Emily McMinn :emcminn]

Attachment: Bug 1705825 - Update proton onboarding background image and caption

Comment 4

[Ed Lee :Mardak]

The patch here had merge conflicts with bug 1707749 and bug 1708335, so the ordering of the patches is important for uplift.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56373c5b3a01
Update proton onboarding background image and caption r=fluent-reviewers,Mardak,flod

Comment 6

[Emily McMinn :emcminn]

Comment on attachment 9219394 [details]
Bug 1705825 - Update proton onboarding background image and caption

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1707749, Bug 1708335
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Styling update to new user onboarding with an updated background image & caption.
  This patch depends on 1707749 and 1708335 and should land after those patches in order to apply cleanly.
• String changes made/needed: none

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/56373c5b3a01

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9219394 [details]
Bug 1705825 - Update proton onboarding background image and caption

Low risk proton uplift, approved for 89 beta 8, thanks.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

String changes made/needed: none

This uplift added a new string in browser/locales/en-US/browser/newtab/onboarding.ftl and requires an approval from the l10n team for an uplift to beta, flod can you look and approve the uplift please? Thanks

Comment 10

[Francesco Lodolo [:flod]]

(In reply to Pascal Chevrel:pascalc from comment #9)

String changes made/needed: none

This uplift added a new string in browser/locales/en-US/browser/newtab/onboarding.ftl and requires an approval from the l10n team for an uplift to beta, flod can you look and approve the uplift please? Thanks

It's OK (it's actually not a new string, so it won't fall back to English. it's changing an existing one making new lines significant).

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9219394 [details]
Bug 1705825 - Update proton onboarding background image and caption

Low risk css for Proton, uplift approved for 89 beta 8, thanks.

Comment 12

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f0b1759e46ef

Comment 13

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that the new image background is successfully displayed on the new users Onboarding page.

Also, I have observed that the "Soraya Osorio — Furniture designer, Firefox fan" image caption is wrongly displayed instead of the "Soraya Osorio — Metal sculptor, Firefox fan" one, but I've logged a new issue for this for better tracking. You can find it here.

Verified using the latest Firefox Nightly (90.0a1 Build ID - 20210504092024) installed on Windows 10 x64, macOS 10.15, and Linux Mint 20.

Comment 14

[Emily McMinn :emcminn]

Hi Marius, thanks! The copy change was intentional, it just happened last minute Friday and didn't make it to the docs :) I've made a note on the other bug and NI'd Meridel to confirm.

Comment 15

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that the new image background and the "Soraya Osorio — Furniture designer, Firefox fan" image caption are successfully displayed on the new users Onboarding page.

Verified using the latest Firefox Beta (89.0b10 Build ID - 20210509185840) installed on Windows 10 x64, macOS 10.15, and Linux Mint 20.