1705833 - [wpt-sync] Sync PR 28555 - [cleanup] Run ComputeMinMaxSizes / Layout on demand for OOF nodes.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 28555 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28555
Details from upstream follow.

b'Ian Kilpatrick <[e-mail]>' wrote:

[cleanup] Run ComputeMinMaxSizes / Layout on demand for OOF nodes.

This performs a relatively large cleanup, but effectively this removes
a bunch of complicated logic for determining if we need to run
NGBlockNode::ComputeMinMaxSizes / Layout, and instead calculates
on-demand within ng_absolute_utils.cc

This is easier to read (IMO), and significantly reduces the API
surface.

Change-Id: I674d4f15354097aebe8131e7f664b52a18ddf692
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2818969
Commit-Queue: Ian Kilpatrick \<[e-mail]>
Reviewed-by: Morten Stenshorne \<[e-mail]>
Reviewed-by: Alison Maher \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#873363}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 28555 applied with additional changes from upstream: 312b5934720a19dd6209890f98f6a7894c0e09e5

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=10dc4c70e3b9b736f36d29e1eac971f4617b5081

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

PASS: 1
FAIL: 1

Safari

PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/560d79b206ef
[wpt PR 28555] - [cleanup] Run ComputeMinMaxSizes / Layout on demand for OOF nodes., a=testonly

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/560d79b206ef