Adjust checkbox styling with faded text and top-aligned box
Categories
(Firefox :: Messaging System, enhancement, P2)
Tracking
()
People
(Reporter: Mardak, Assigned: Mardak)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-modals][proton-onboarding][priority:2a][proton-uplift])
Attachments
(3 files)
|
16.81 KB,
image/png
|
Details | |
|
16.14 KB,
image/png
|
Details | |
|
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
example light
light should have #5B5B66
dark should have #BFBFC9
multiline label should have checkbox line up with first line
https://www.figma.com/file/FjUe6ORvXZgJvI3rPuTV33/Desktop-UI-(Mozilla-Confidential-)?node-id=2814%3A5112
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
Change in-content-deemphasized-text light (but not dark) to match specs and use it for dialog checkbox.
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f48063c60dec Adjust checkbox styling with faded text and top-aligned box r=Gijs
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 5•3 years ago
•
|
||
Comment on attachment 9216575 [details]
Bug 1705882 - Adjust checkbox styling with faded text and top-aligned box r?Gijs
Beta/Release Uplift Approval Request
- User impact if declined: Checkbox labels have the wrong styling
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: 1. Open up a prompt with a checkbox, e.g., default browser
- See checkbox label is faded color
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Small CSS change to proton prompts
- String changes made/needed: none
|
|
Assignee | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
||
Comment 6•3 years ago
|
||
This issue is verified as fixed in our latest Nightly build 90.0a1 (2021-04-22) on Mac, Windows and Ubuntu.
|
||
Updated•3 years ago
|
|
|
||
Comment 7•3 years ago
•
|
||
Comment on attachment 9216575 [details]
Bug 1705882 - Adjust checkbox styling with faded text and top-aligned box r?Gijs
Approved for 89 beta 5, thanks.
|
|
||
Comment 8•3 years ago
|
||
| bugherder uplift | ||
|
|
||
Comment 9•3 years ago
|
||
This issue is verified as fixed in our latest Beta 89.0b5 on Mac, Windows and Ubuntu.
|
|
Assignee | |
Updated•3 years ago
|
Description
•