Closed Bug 1705913 Opened 5 years ago Closed 3 years ago

ASan build on debian failing with "ld.lld: error: duplicate symbol: operator delete"

Categories

(Firefox Build System :: Toolchains, defect)

defect

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: tsmith, Unassigned)

Details

Lee has been seeing this trying to do ASan builds locally (on Debian).

This is from a clobber build. ./mach bootstrap was also used recently.

62:05.48 ld.lld: error: duplicate symbol: operator delete
62:05.48 >>> defined at asan_new_delete.cpp:163 (/builds/worker/fetches/llvm-project/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cpp:163)
62:05.49 >>> asan_new_delete.cpp.o:(operator delete) in archive /home/lee/.mozbuild/clang/lib/clang/11.0.1/lib/linux/libclang_rt.asan_cxx-x86_64.a
62:05.49 >>> defined at cxxalloc.h:59 (/home/lee/central/obj-ubsan/dist/include/mozilla/cxxalloc.h:59)
62:05.49 >>> /home/lee/central/obj-ubsan/browser/app/../../memory/mozalloc/cxxalloc.o:(.text+0x60)

He also tried a mozconfig that I am using but still hit the issue. I am unable to reproduce this on Ubuntu.

mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/objdir-ff-ubsan

mk_add_options MOZ_MAKE_FLAGS=-j30

ac_add_options --enable-address-sanitizer
ac_add_options --enable-undefined-sanitizer
ac_add_options --enable-fuzzing

export ASAN_OPTIONS="detect_leaks=0"
export RUSTFLAGS="$RUSTFLAGS -Zsanitizer=address"

ac_add_options --disable-elf-hack
ac_add_options --disable-jemalloc
ac_add_options --disable-crashreporter

export MOZ_DEBUG_SYMBOLS=1
ac_add_options --enable-debug-symbols
ac_add_options --disable-install-strip
ac_add_options --enable-valgrind
ac_add_options --disable-optimize
ac_add_options --disable-debug
ac_add_options --enable-av1

Any ideas what might be going on?

I tested with a fresh install of Debian 10 in a VM and followed the build instructions. I had no issues creating an ASan build.

Is this still an issue?

Flags: needinfo?(twsmith)

Good question. I wasn't able to reproduce the issue.

Lee have you tried an ASan build lately?

Flags: needinfo?(twsmith) → needinfo?(lsalzman)

Note: adding the following line to my mozconfig reduces the build time down to ~10 minutes to test a clean build.

ac_add_options --enable-optimize="-OO"

I believe it seems to build here now.

Flags: needinfo?(lsalzman)

Let's close, then. Please feel free to reopen if you can reproduce.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.