1705934 - Rename selectPills(pill) to selectSiblingPills(pill)

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, task)

Description

[Thomas D. (:thomas8)]

The function name of selectPills(pill) is irritating because there's no hint that this will select all the sibling pills (all pills in the row) rather than the pill(s) handed over in the argument.

Comment 1

[Thomas D. (:thomas8)]

Attachment: 1705934_selectSiblingPills.diff

Bug 1705934 - Rename selectPills(pill) to selectSiblingPills(pill). r=aleca

• I moved selectSiblingsPills() before selectAllPills() to maintain a logical order when we'll soon have deselectAllPills() from bug 1663062. Pls note there might be some diff artifacts from this move because the functions are so similar.
• Also corrected and improved some related function comments (like the false claim that the pill handed over to the function is the focus pill).

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9216624 [details] [diff] [review]
1705934_selectSiblingPills.diff

Review of attachment 9216624 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 3

[Thomas D. (:thomas8)]

Thanks for the review!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/865b1ee82cfb
Rename selectPills(pill) to selectSiblingPills(pill). r=aleca