Closed Bug 1705974 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 28566 - Add initiallyopen attribute to the <popup> element

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28566 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28566
Details from upstream follow.

b'Mason Freed <masonf@chromium.org>' wrote:

Add initiallyopen attribute to the <popup> element

This add an attribute called initiallyopen to the \<popup> element.
When this attribute is present on page load, the first such element
will be shown by default.

See [1] for the conversation and Open-UI resolution.

This CL also re-points the explainer links for all popup tests
to the new Open-UI repo.

[1] https://github.com/WICG/open-ui/issues/311#issuecomment-820655960

Bug: 1168738
Change-Id: Ib95d12234f359d503dc168e6799dd2a17b0dc18e

Reviewed-on: https://chromium-review.googlesource.com/2832157
WPT-Export-Revision: 702723a7a1882d2bcd471cc25a2f541b5a9b62ff

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 13 tests

Status Summary

Firefox

OK : 6
PASS : 1
FAIL : 17
ERROR: 2

Chrome

OK : 8
PASS : 24
FAIL : 5

Safari

OK : 6
PASS : 1
FAIL : 17
ERROR: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/interactive-elements/the-popup-element/popup-anchor-nesting.tentative.html: ERROR (Chrome: OK, Safari: ERROR)
/html/semantics/interactive-elements/the-popup-element/popup-element-basic.tentative.html
popup element exists: FAIL (Chrome: PASS, Safari: FAIL)
The IDL "open" content attribute must have no effect, and must not be reflected to the WebIDL.: FAIL (Chrome: PASS, Safari: FAIL)
The only visibility control for <popup> is through .show() and .hide().: FAIL (Chrome: PASS, Safari: FAIL)
/html/semantics/interactive-elements/the-popup-element/popup-initiallyopen.tentative.html
The initiallyopen attribute should affect page load only: FAIL (Chrome: FAIL, Safari: FAIL)
/html/semantics/interactive-elements/the-popup-element/popup-invoking-attribute.tentative.html
Basic test of the 'popup' attribute on a button: FAIL (Chrome: PASS, Safari: FAIL)
/html/semantics/interactive-elements/the-popup-element/popup-light-dismiss-on-scroll.tentative.html
Scrolling light-dismisses all popups: FAIL (Chrome: PASS, Safari: FAIL)
/html/semantics/interactive-elements/the-popup-element/popup-light-dismiss.tentative.html: ERROR (Chrome: OK, Safari: ERROR)
/html/semantics/interactive-elements/the-popup-element/popup-shadow-dom.tentative.html
Popups located inside shadow DOM can still be shown: FAIL (Chrome: PASS, Safari: FAIL)
anchor references do not cross shadow boundaries: FAIL (Chrome: PASS, Safari: FAIL)
anchor references use the DOM tree not the flat tree: FAIL (Chrome: PASS, Safari: FAIL)
The popup stack is preserved across shadow-inclusive ancestors: FAIL (Chrome: PASS, Safari: FAIL)
/html/semantics/interactive-elements/the-popup-element/popup-stacking.tentative.html
popup stacking behavior: FAIL (Chrome: PASS, Safari: FAIL)
popups should be closed by dialogs: FAIL (Chrome: PASS, Safari: FAIL)
dialogs should not be closed by popups: FAIL (Chrome: PASS, Safari: FAIL)
/html/semantics/interactive-elements/the-popup-element/popup-hidden-display.tentative.html: FAIL (Chrome: PASS, Safari: FAIL)
/html/semantics/interactive-elements/the-popup-element/popup-initiallyopen-display.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)
/html/semantics/interactive-elements/the-popup-element/popup-open-display.tentative.html: FAIL (Chrome: PASS, Safari: FAIL)
/html/semantics/interactive-elements/the-popup-element/popup-open-overflow-display.tentative.html: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1172dbf20680 [wpt PR 28566] - Add initiallyopen attribute to the <popup> element, a=testonly https://hg.mozilla.org/integration/autoland/rev/9586a01e14a5 [wpt PR 28566] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.