Open Bug 1705976 Opened 2 months ago Updated 14 days ago

land a test that zoom constraints get propaged to fission oop iframes

Categories

(Core :: Panning and Zooming, task)

task

Tracking

()

Fission Milestone M8

People

(Reporter: tnikkel, Assigned: tnikkel)

References

(Blocks 1 open bug)

Details

I haven't tested but based on the current code I assume that zoom constraints do not get propagated to oop iframes, leading them to get default zoom constraints which don't allow zooming. While this doesn't affect pinch zooming because that automatically gets routed to the root content apzc this would affect double tap to zoom.

The patch https://phabricator.services.mozilla.com/D112315 from bug 1705623 would have fixed this in one way, but in bug 1705622 we decided to go a different way, which also fixes this case.

This bug is to write a test for this.

Blocks: desktop-zoom
Fission Milestone: --- → M8
Assignee: nobody → tnikkel

I think this is invalid now. I don't think we use the zoom constraints on iframes for anything. Do you agree?

Flags: needinfo?(botond)

I think the intention was to write a test for a scenario similar to the following:

  • The root content document has user-scalable=no in its meta viewport tag
  • There is a cross-origin iframe
  • Double-tap on content inside the iframe
  • The browser should respect the user-scalable=no and not zoom

We can probably add a test like that as a simple variation of helper_doubletap_zoom_oopif.html.

(I do agree that, with bug 1713715 in place, we no longer take a codepath that looks at the iframe zoom constraints, which makes the test less interesting.)

Flags: needinfo?(botond)
You need to log in before you can comment on or make changes to this bug.