Add an easy way to inspect the page without auto-closing
Categories
(Testing :: Raptor, defect, P2)
Tracking
(Not tracked)
People
(Reporter: emilio, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
$ ./mach raptor --browsertime -t yahoo-mail --debug --debug-mode
Still auto-closes the page, how can I inspect the page without that?
This works:
diff --git a/testing/raptor/browsertime/browsertime_pageload.js b/testing/raptor/browsertime/browsertime_pageload.js
index 3ed71dede5fd..0e926759fc50 100644
--- a/testing/raptor/browsertime/browsertime_pageload.js
+++ b/testing/raptor/browsertime/browsertime_pageload.js
@@ -26,6 +26,8 @@ module.exports = async function(context, commands) {
context.log.info("Cycle %d, starting the measure", count);
await commands.measure.start(url);
+
+ await new Promise(r => { /* wait forever */ });
}
context.log.info("Browsertime pageload ended.");
return true;
But it's obviously not ideal.
Updated•4 years ago
|
Reporter | ||
Comment 1•2 years ago
|
||
This is something I always have to do when investigating performance regressions :(
Comment 2•2 years ago
•
|
||
:emilio, there's a PR here that just merged for this: https://github.com/sitespeedio/browsertime/pull/1798
It'll allow you to add a commands.debug.breakpoint()
call where you want to stop (you can continue by setting browsertime.pause = false
in the console). If you don't add a breakpoint, then it'll stop at the end of your script iterations but just before the browser is set to close for the next browser iteration.
I'm working on a patch to add this for us in bug 1655554.
Comment 3•2 years ago
|
||
The patch in bug 1655554 is landing now, I'm going to close this as a duplicate. :emilio, if it's still an issue feel free to re-open it.
Description
•