Closed Bug 1706086 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 28573 - Fixed crash for nested removals for datalist

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28573 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28573
Details from upstream follow.

b'Rune Lillesveen <futhark@chromium.org>' wrote:

Fixed crash for nested removals for datalist

The case where we did a remove in the subtree already being removed, was
handled for style traversal roots. For the datalist element, the nested
removal does not necessarily happen in the same subtree. That means the
traversal root update in the outer removal would not necessarily work.

Instead, just fall back to the document root as the traversal root.

Bug: 1199861
Change-Id: Id95f3e7b1010f46183c0f9d1223e6726b29f0fe4
Reviewed-on: https://chromium-review.googlesource.com/2835850
WPT-Export-Revision: ce67c9642a176e4d25d3927b101dcc4052a8ab45

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/18f326442118 [wpt PR 28573] - Fixed crash for nested removals for datalist, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.