Closed Bug 1706097 Opened 3 years ago Closed 3 years ago

AUTO_PROFILER_LABEL_DYNAMIC_NSCSTRING_NONSENSITIVE doesn't record BHR label frames when the profiler is not running

Categories

(Core :: XPCOM, enhancement)

Product:
Core
Component:
XPCOM
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(1 file)

Bug 1706097 - AUTO_PROFILER_LABEL_DYNAMIC_NSCSTRING_NONSENSITIVE should record BHR label frames even when the profiler is not running, r=gerald.
48 bytes, text/x-phabricator-request
Details | Review

Bug 1586920 added the AUTO_PROFILER_LABEL_DYNAMIC_NSCSTRING_NONSENSITIVE macro (among others) to record some label frames with dynamic strings in BHR stacks, but unfortunately there's a profiler_is_active() call in it that prevents the data from being collected.

Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a2e13b7f4704
AUTO_PROFILER_LABEL_DYNAMIC_NSCSTRING_NONSENSITIVE should record BHR label frames even when the profiler is not running, r=gerald.

https://hg.mozilla.org/mozilla-central/rev/a2e13b7f4704

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: