17061 - unknown-content-type dialog is being thrown even when a url load fails

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P2)

Description

[Judson Valeski]

steps to reproduce:
Goto: ftp://ftp.boulderdesign.com and when it asks you for auth info, hit
cancel.


This causes FTP to fire OnStopRequest() out to the docLoader w/ a failure status
code and error msg. That should be sufficient to prevent the save as dailog from
being opened.

Comment 1

[Bill Law]

Changed my mind; mozilla would taste fine without this being fixed.

Comment 2

[Judson Valeski]

morse, my fix for 17521 is independent of this.

Comment 3

[Bill Law]

This seems like a bit of a nasty problem.  We first get the OnStartRequest
(which triggers the unknown-content dialog), followed by the OnStopRequest.  The
latter comes too late to stop the dialog.

On the face of it, I can't see how to discern any status from inside
OnStartRequest.  I think the fix should look something like:
  if ( channel->Status() == OK ) {
     // Do HandleUnknownContent stuff now.
  }

I'm adding rpotts to cc: list 'cause if anybody knows, it would be him.  Rick?

Comment 4

[Judson Valeski]

AsyncOpen will fix this.

Comment 5

[don]

Not required for beta 1.

Comment 6

[leger]

Moving all UE/UI bugs to new component: User Interface: Design Feedback
UE/UI component will be deleted.

Comment 7

[don]

Move to M16 for now ...

Comment 8

[don]

Move to M21 target milestone.

Comment 9

[Bill Law]

I don't think this is a problem any more.  Unfortunately, boulderdesign.com
seems to have redone their ftp authorization process so I can't reproduce.  If
another site demonstrates the problem in the future, we'll deal with it.

Comment 10

[Zach Lipton [:zach]]

Chaning the qa contact on these bugs to me. MPT will be moving to the 
owner of this component shortly. I would like to thank him for all his hard 
work as he moves roles in mozilla.org...Yada, Yada, Yada...

Comment 11

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/20bddf4f3a6b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17061: Prevent appBarLayout from leaking.