PPEmbed - AlertCheck dialog has a "Cancel" button. It shouldn't.

RESOLVED FIXED in mozilla1.3beta

Status

Core Graveyard
Embedding: Mac
RESOLVED FIXED
16 years ago
2 years ago

People

(Reporter: Teruko Kobayashi, Assigned: Conrad Carlen (not reading bugmail))

Tracking

({topembed-})

Trunk
mozilla1.3beta
PowerPC
Mac OS X
topembed-

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

16 years ago
PPEmbed - "Cancel" button does not work in warning dialog when accessing an
encrypted website.

Steps of reproduce
1. Launch PPEmbed 
2. Go to www.citibank.de
3. click on "Zu Ihrem Konto & Depot"
The waring dialog "You have requested an encrypted page..." will show up.
4. click on the "Cancel" button in the upcoming info form

Actual Result
nothing happens

Expected Result
either the button should have an action or the button should be removed.

Tested 9-19 branch PPEmbed build.
(Assignee)

Comment 1

16 years ago
OK - I see the problem and know what it is. I was a side-tracked by the fact
that the page didn't load ;-)

Fixing summary.
Status: NEW → ASSIGNED
Summary: PPEmbed - "Cancel" button does not work in warning dialog when accessing an encrypted website → PPEmbed - AlertCheck dialog has a "Cancel" button. It shouldn't.
Target Milestone: --- → mozilla1.2alpha

Updated

16 years ago
QA Contact: mdunn → bmartin
(Assignee)

Comment 2

16 years ago
Created attachment 100485 [details] [diff] [review]
patch

The same dialog resource for nsIPromptService::ConfirmCheck was being used for
nsIPromptService::AlertCheck.
(Assignee)

Comment 3

16 years ago
Created attachment 100486 [details]
updated resource file

Added the right dialog resource for AlertCheck, fixed up the dialogs to be
wider, and the checkboxes to be taller. Also, fixed the size/placement bindings
in the dialogs so that apps wanting larger dialogs for larger dialog fonts can
more easily change this in Constructor while preserving the layout of items.

Comment 4

16 years ago
Internal reference:
http://bugscape.mcom.com/show_bug.cgi?id=20193
Keywords: topembed

Comment 5

16 years ago
mozilla build 1.0.2 Gecko 20020925

I am able to reproduce this problem. But under steps to reproduce after #3 I had
to click on the back arrow button to get the warning dialog.  
Clicking Cancel does not dismiss the dialog at all.

Workaround: If you click on OK twice it will take you back to www.citibank.de
(Assignee)

Comment 6

16 years ago
> Workaround: If you click on OK twice it

Hello, there is a patch here ;-) There is *not* supposed to be a cancel button.

Updated

16 years ago
Keywords: topembed → topembed-
(Assignee)

Comment 7

16 years ago
Can I get r=/sr= on this? The patch is mostly to resources so there's not much
to see but it's explained in comment #2 and #3.
Target Milestone: mozilla1.2alpha → mozilla1.3beta

Comment 8

16 years ago
Comment on attachment 100486 [details]
updated resource file

rs=sfraser
Attachment #100486 - Flags: superreview+
(Assignee)

Comment 10

16 years ago
Fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.