Closed
Bug 170611
Opened 22 years ago
Closed 22 years ago
PPEmbed - AlertCheck dialog has a "Cancel" button. It shouldn't.
Categories
(Core Graveyard :: Embedding: Mac, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.3beta
People
(Reporter: teruko, Assigned: ccarlen)
References
()
Details
(Keywords: topembed-)
Attachments
(2 files)
1.35 KB,
patch
|
mikepinkerton
:
review+
|
Details | Diff | Splinter Review |
12.63 KB,
application/octet-stream
|
sfraser_bugs
:
superreview+
|
Details |
PPEmbed - "Cancel" button does not work in warning dialog when accessing an encrypted website. Steps of reproduce 1. Launch PPEmbed 2. Go to www.citibank.de 3. click on "Zu Ihrem Konto & Depot" The waring dialog "You have requested an encrypted page..." will show up. 4. click on the "Cancel" button in the upcoming info form Actual Result nothing happens Expected Result either the button should have an action or the button should be removed. Tested 9-19 branch PPEmbed build.
Assignee | ||
Comment 1•22 years ago
|
||
OK - I see the problem and know what it is. I was a side-tracked by the fact that the page didn't load ;-) Fixing summary.
Status: NEW → ASSIGNED
Summary: PPEmbed - "Cancel" button does not work in warning dialog when accessing an encrypted website → PPEmbed - AlertCheck dialog has a "Cancel" button. It shouldn't.
Target Milestone: --- → mozilla1.2alpha
Updated•22 years ago
|
QA Contact: mdunn → bmartin
Assignee | ||
Comment 2•22 years ago
|
||
The same dialog resource for nsIPromptService::ConfirmCheck was being used for nsIPromptService::AlertCheck.
Assignee | ||
Comment 3•22 years ago
|
||
Added the right dialog resource for AlertCheck, fixed up the dialogs to be wider, and the checkboxes to be taller. Also, fixed the size/placement bindings in the dialogs so that apps wanting larger dialogs for larger dialog fonts can more easily change this in Constructor while preserving the layout of items.
Comment 4•22 years ago
|
||
Internal reference: http://bugscape.mcom.com/show_bug.cgi?id=20193
Keywords: topembed
Comment 5•22 years ago
|
||
mozilla build 1.0.2 Gecko 20020925 I am able to reproduce this problem. But under steps to reproduce after #3 I had to click on the back arrow button to get the warning dialog. Clicking Cancel does not dismiss the dialog at all. Workaround: If you click on OK twice it will take you back to www.citibank.de
Assignee | ||
Comment 6•22 years ago
|
||
> Workaround: If you click on OK twice it
Hello, there is a patch here ;-) There is *not* supposed to be a cancel button.
Updated•22 years ago
|
Assignee | ||
Comment 7•22 years ago
|
||
Can I get r=/sr= on this? The patch is mostly to resources so there's not much to see but it's explained in comment #2 and #3.
Target Milestone: mozilla1.2alpha → mozilla1.3beta
Comment 8•22 years ago
|
||
Comment on attachment 100486 [details]
updated resource file
rs=sfraser
Attachment #100486 -
Flags: superreview+
Comment 9•22 years ago
|
||
Comment on attachment 100485 [details] [diff] [review] patch r=pink
Attachment #100485 -
Flags: review+
Assignee | ||
Comment 10•22 years ago
|
||
Fixed
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•