1706167 - Holding down Back button, the Back button's page titles are wrong (Fission no-bfcache, SHIP only?)

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Attachment: history_states.html

@ Olli, do you think this history state bug needs to block Fission MVP?

When trying to reproduce bug 1704809 using its history_state.html test case, Nika noticed that the Back button's page titles are wrong with Fission SHIP only.

Bug 1704809 describes a different history state bug when bfcache is enabled: when we restore from bfcache, we don't fire popstate.

Comment 1

[Chris Peterson [:cpeterson]]

Olli says this bug should block Fission M7a.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

oh, fun. Title becomes 1 also without Fission, but only in child process (document.title). The UI shows the original title in non-Fission.
Chrome has the same bizarre behavior as e10s.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Oh, and if you click submit again, also e10s changes the titles, which makes sense.

I think the behavior in Fission makes most sense.
E10s has the least reasonable behavior.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1706167, don't update SessionHistoryEntry.title when doing same document navigations, r=peterv

The change to DoNotifyPossibleTitleChange handling is needed so that we flush the pending title change
before adding a new active entry.

aUpdateEntryInSessionHistory is a bit odd name, since it is really about SHIP only. The patch isn't trying to
fix non-SHIP UI issues, but just give Fission similar behavior what Chrome has.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/434d5ad2b9ae
don't update SessionHistoryEntry.title when doing same document navigations, r=peterv

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/434d5ad2b9ae

Comment 7

[Julien Cristau [:jcristau]]

Does this need uplift or can it ride to 91?

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

This is an edge case and has been in a bit different way broken in non-Fission forever, so no need to uplift.

Comment 9

[Chris Peterson [:cpeterson]]

(In reply to Olli Pettay [:smaug] from comment #8)

This is an edge case and has been in a bit different way broken in non-Fission forever, so no need to uplift.

In that case, setting status-firefox90=wontfix.