1706169 - [wpt-sync] Sync PR 28586 - [ReadableByteStream] Handle enqueuing when detach

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 28586 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28586
Details from upstream follow.

b'Adam Rice <[e-mail]>' wrote:

[ReadableByteStream] Handle enqueuing when detach

Attempting to call enqueue() on a ReadableByteStreamController after
controller.byobRequest.view.buffer had been detached would crash with a
null pointer dereference.

Make it throw an exception instead.

BUG=1200302

Change-Id: I86b1511ef154a42ca78271618e00d8e1c5e6ae5d
Reviewed-on: https://chromium-review.googlesource.com/2836768
WPT-Export-Revision: ee5b1100689c6da314ff267024f81456ec568c9e

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=61add0afce69517e76ce8b5070c650dd983aa7de

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL : 1

Chrome

CRASH: 1

Safari

OK : 1
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/streams/readable-byte-streams/enqueue-with-detached-buffer.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: CRASH, Safari: OK)
enqueue after detaching byobRequest.view.buffer should throw: FAIL (Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/streams/readable-byte-streams/enqueue-with-detached-buffer.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: CRASH, Safari: OK)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7f4f9231b65
[wpt PR 28586] - [ReadableByteStream] Handle enqueuing when detach, a=testonly

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e7f4f9231b65