1706195 - Refactor test code that deals with compositorAPZTestData

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task)

Description

[Kartikaya Gupta (email:[e-mail])]

Spinoff from https://phabricator.services.mozilla.com/D112501?id=428746#inline-627046

There's some duplicated code around handling the getCompositorAPZTestData() structure that can be refactored.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/jobs?repo=try&revision=67feb57df3ed51a0834380c13dc9f45490488ebb

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1706195 - Extract a parsePoint helper function. r?hiro

The helper function will parse both (1, 2) as well as (x=1, y=2)
strings, similarly to how parseRect works.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1706195 - Drop requirePaints argument in test helper. r?hiro

Even if requirePaints is false, we still index into the APZ test
data using paints.length - 1 and use those data structures
unconditionally. Therefore the code still requires a paint either
way in order to not throw an exception.

Depends on D116531

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1706195 - Extract a getLastApzcTree helper function. r?hiro

Depends on D116532

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31f06b7e22fa
Extract a parsePoint helper function. r=hiro
https://hg.mozilla.org/integration/autoland/rev/9b7b9db3a1f4
Drop requirePaints argument in test helper. r=hiro
https://hg.mozilla.org/integration/autoland/rev/12cc3a645367
Extract a getLastApzcTree helper function. r=hiro

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/31f06b7e22fa
https://hg.mozilla.org/mozilla-central/rev/9b7b9db3a1f4
https://hg.mozilla.org/mozilla-central/rev/12cc3a645367