170621 - static build changes for viewer.exe mfcembed.exe and winembed.exe

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Cathleen]

Comment 1

[Garrett Arch Blythe]

Attachment: Enable static builds for test apps.

Request for r=, sr=

Enable static builds for test apps.
Fix nsToolkit init problem.

Comment 2

[timeless]

Comment on attachment 105974 [details] [diff] [review]
Enable static builds for test apps.

so um, if we ever flip over to packaging static builds, the file size is going
to quadruple...

Comment 3

[hacker formerly known as [e-mail]]

Comment on attachment 105974 [details] [diff] [review]
Enable static builds for test apps.

That entire toplevel Makefile block is wrong.  Why do we want to start building
viewer in our nighlty builds?  Why is the build order only modified for the
static builds?

Comment 4

[Garrett Arch Blythe]

Comment #3:  Why do we want to start building viewer in our nighlty builds?

This patch does not change when viewer gets built, only how it is linked.  If
viewer was not previously getting built, this patch should not cause it to get
built.


Comment #3:  Why is the build order only modified for the static builds?

Unfortunately, all the linkage dependencies in a static build are not available
until the end of the build cycle.  If you require further proof, I will provide
specifics upon request.

Comment 5

[hacker formerly known as [e-mail]]

+ifneq (,$(ENABLE_TESTS)$(MOZILLA_OFFICIAL))

So if tests are enabled and/or it's a nightly build, it's going to build viewer
& the other test harnesss.  

Right, static builds require that executables are built last.  My point was why
bother with the confusing ifdefs and just move the directories to the bottom of
the list like we did for gtkembed?

Comment 6

[Garrett Arch Blythe]

Comment #5, ouch, you are certainly correct and sorry I missed the implications.

I took the "ifneq (,$(ENABLE_TESTS)$(MOZILLA_OFFICIAL))" line orignally from
mozilla/embedding/Makefile.in as it appeared the embedding tests get built that
way in a non static build.

Will change, and will apply the gtkembed-like changes as well.

thx!

Comment 7

[Garrett Arch Blythe]

Attachment: Enable static build for test apps.

2nd attempt, tries to address concerns raised by cls.

Only build test apps at end of build to avoid special cases.
Do not enable viewer to be build when official static build.

Still questionable on win32 to build mfcembed and winembed for an official
static build, but preserved logic found in original
mozilla/embedding/Makefile.in

Request for r=

Comment 8

[hacker formerly known as [e-mail]]

Comment on attachment 106043 [details] [diff] [review]
Enable static build for test apps.

My linux static build broke in viewer attempting to create viewer_gtk.	It
couldn't find -lxpconnect.    Viewer has one of those classic nasty Makefiles. 
You'll need to add the extra linking options for each of the
viewer_{gtk,qt,xlib} targets.

Also, in the toplevel Makefile.in, you should have the test apps build after
mozilla.

Comment 9

[Garrett Arch Blythe]

Sure thing, will fix.  thx!
garrett

Comment 10

[Garrett Arch Blythe]

Attachment: Revised patch to fix linux static build of viewer

Hopefully the final patch to enable static builds of test apps.

Request for r=

Comment 11

[hacker formerly known as [e-mail]]

Comment on attachment 109495 [details] [diff] [review]
Revised patch to fix linux static build of viewer

r=cls

Comment 12

[Garrett Arch Blythe]

checked in