1706272 - Remove now unnecessary DevTools workaround for IDX_OverrideDPPX in BrowsingContext.cpp

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

In https://searchfox.org/mozilla-central/rev/b6f52976b562008c9d9ceeda22907e1eda506c8e/docshell/base/BrowsingContext.cpp#2694-2695 , there's a FIXME mentioning DevTools code setting the overrideDppx from content process.
DevTools now set the flag from the parent process (done in Bug 1703178), so we can probably remove the devtools specific and probably add an assertion to ensure this is only set from parent process.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

cc kmag since I think he's the once that introduced the workaround for us in the first place

Comment 2

[Chris Peterson [:cpeterson]]

Assigning to kmag.

Tracking for Fission M8. Setting overrideDppx in the parent process was fixed in Fission M7a by bug 1703178, but (AFAICT) removing this code from the content process seems low-enough priority that we can fix in Fission M8.

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1706272: Remove owning-process-can-set workaround for overrideDPPX. r=nika

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/178d0ad97b95
Remove owning-process-can-set workaround for overrideDPPX. r=nika

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/178d0ad97b95