1706326 - Pressing Enter on Add Engine shortcut button doesn't add the engine

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Keyboard navigating to an Add Engine shortcut and pressing Enter doesn't add the engine. It works correctly in the separate search bar.

STR:

1. visit https://addons.mozilla.org/
2. open the urlbar and navigate with th keyboard to the Add Engine shorctut button for AMO
3. press Enter

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I think this is something we want to fix sooner than later.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1706326 - Pressing Enter on Add Engine shortcut button doesn't add the engine. r=adw

The patch removes the special .webEngine expando and rather use the class to
recognize add engine shortcuts, similarly to how old shortcut buttons did.
It also reuses the add engine handling in SearchOneOffs.js::_on_command rather
than duplicating it.
It is also no more necessary to provide a wrapper around
SearchUIUtils.addOpenSearchEngine because it would only be used once.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a358d68f94a1
Pressing Enter on Add Engine shortcut button doesn't add the engine. r=adw

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/a358d68f94a1

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 9217446 [details]
Bug 1706326 - Pressing Enter on Add Engine shortcut button doesn't add the engine. r=adw

Beta/Release Uplift Approval Request

• User impact if declined: Adding search engines directly from the address bar shortcut buttons is part of MR1, this solves an accessibility problem where pressing Enter on such button doesn't work.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Go to a page providing an opensearch engine (bugzilla or AMO for example), click on the urlbar to open it, navigate with the keyboard down button until you reach the add engine button, press Enter to add it.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch is reusing existing code, and has an automated test.
• String changes made/needed:

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9217446 [details]
Bug 1706326 - Pressing Enter on Add Engine shortcut button doesn't add the engine. r=adw

Approved for 89 beta 3, thanks.

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/e3acb8b0fc69

Comment 8

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed on Firefox 89 beta 5 and latest Nightly 90.0a1 under Win 10 64-bit, Mac OSX 11.2.3 and Ubuntu 18.04 64-bit.