1706369 - Move nimbus manifest to its own file

Status: VERIFIED FIXED

(Firefox :: Nimbus Desktop Client, enhancement, P1)

Description

[Kate Hudson :k88hudson]

We should move the nimbus manifest for Desktop to its own file so it can be picked up by Experimenter

Comment 1

[Kate Hudson :k88hudson]

Attachment: Bug 1706369 - Move nimbus manifest to its own file

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f67e31e5000b
Move nimbus manifest to its own file r=andreio

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f67e31e5000b

Comment 4

[Kate Hudson :k88hudson]

Comment on attachment 9217171 [details]
Bug 1706369 - Move nimbus manifest to its own file

Beta/Release Uplift Approval Request

• User impact if declined: This is a dependent revision for several other uplifts including https://bugzilla.mozilla.org/show_bug.cgi?id=1698204 https://bugzilla.mozilla.org/show_bug.cgi?id=1709344, which won't apply cleanly without it.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Verify that fallback preferences work as expected:

1. Change browser.proton.enabled to false
2. Load about:welcome
3. Ensure that the old non-proton experience shows up

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small refactor that moves some configuration to a separate file.
• String changes made/needed:

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9217171 [details]
Bug 1706369 - Move nimbus manifest to its own file

Low risk, has tests and baked on beta, approved for 89 beta 9, thanks.

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/feb4d51f26e6

Comment 7

[Mihai Boldan, Desktop QA [:mboldan]]

I managed to verify the issue on 90.0a1 (2021-05-05) and the pref flip is working as expected.
Tests were performed under Windows 10x64, Ubuntu 20.04x64 and under macOS 10.15.
I noticed that on Firefox 89.0b8 the pref flip is working too, but from Comment 6 it seems that this build should be affected. Kate, is this expected?
Note that I verified the issue by following the steps from Comment 4.

Comment 8

[Kate Hudson :k88hudson]

Yes, this is expected – to clarify, the functionality should be unchanged for users, the test steps were to verify that no regression has occurred. Thanks!

Comment 9

[Mihai Boldan, Desktop QA [:mboldan]]

Thanks for the clarification, Kate.
It seems that everything looks good on Firefox 90.0a1 (2021-05-05) and on Firefox 89.0b9.
Tests were performed under Windows 10x64, macOS 10.15 and under Ubuntu 20.04x64.0