1706384 - "milestone banner" in protection panel is missing Proton style

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P2)

Description

[Sören Hentzschel]

Attachment: screenshot

The banner in the protection panel for a reached milestone (x blocked tracker since y) does not fit the Proton style, like color and border-radius. Please see the bottom of the attached screenshot. The font size is also a bit too large. It was already larger than the other content before Proton but since Proton everything is bigger so this makes this element really big.

Comment 1

[Emma Malysz]

Attachment: Bug 1706384, apply proton styles to milestone banner in protections panel

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07e8c2f36bad
apply proton styles to milestone banner in protections panel r=mhowell

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/07e8c2f36bad

Comment 4

[Tyler Duzan]

Thanks for the quick fix. Let's go ahead and uplift this.

Comment 5

[Emma Malysz]

Comment on attachment 9220620 [details]
Bug 1706384, apply proton styles to milestone banner in protections panel

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple css fixes
• String changes made/needed: n/a

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9220620 [details]
Bug 1706384, apply proton styles to milestone banner in protections panel

Low risk, MR1 patch in early beta, approved for 89 beta 10, thanks.

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/8efe7fe8db84

Comment 8

[Ciprian Georgiu, Desktop QA]

I've verified this issue on latest Nightly 90.0a1 and Beta 89.0b10 running Win 10 x64 and macOS 10.15. It seems that the milestone celebration banner is still not correctly displayed. The shield icon appear flatten in the panel on Win 10/macOS - please see the screenshot. Also, on mac, the rounded corners of the banner, appear cut off at the bottom - see screenshot.

Emma, could you please take a look at this?

Comment 9

[Emma Malysz]

Hi Ciprian, thanks for attaching the screenshots. Can you give me STR for the flattened shield icon? I wasn't able to reproduce on my device or through the test.

For the second issue, it seems a fix for that should be covered in Bug 1705098.

Comment 10

[Ciprian Georgiu, Desktop QA]

(In reply to Emma Malysz from comment #9)

Hi Ciprian, thanks for attaching the screenshots. Can you give me STR for the flattened shield icon? I wasn't able to reproduce on my device or through the test.

Hi! Sure, you can follow these steps:

1. Set browser.contentblocking.cfr-milestone.milestones to [15, 5000, 10000, 20000]
2. Make sure that browser.contentblocking.cfr-milestone.milestone-achieved is set to 0
3. Set browser.newtabpage.activity-stream.asrouter.providers.cfr to {"id":"cfr","enabled":true,"type":"local","localProvider":"CFRMessageProvider","frequency":{"custom":[{"period":"daily","cap":10}]},"categories":["cfrAddons","cfrFeatures"],"updateCycleInMs":3600000}
4. Create and set browser.contentblocking.cfr-milestone.update-interval to 10
5. Go to cnn.com, then refresh the webpage until Firefox reaches the first milestone set, i.e. in this case, the banner will appear when FF has 15 blocked trackers (this can be checked in about:protections page, or directly in the ETP panel, on the right side of the Protection Dashboard section).
6. Click on the shield icon.

Let me know if this work for you.

Comment 11

[Emma Malysz]

Thanks! I filed Bug 1711148

Comment 12

[Ciprian Georgiu, Desktop QA]

Thank you! I've also tested this on latest Beta 89.0b12 and Nightly 90.0a1 with Ubuntu 18.04 x64.

Since the milestone banner has proton style applied with this patch, and besides the issues mentioned in comment 8 (for which we have bug 1711148 and bug 1705098) I haven't encountered any other ones, I'll close this bug as verified fixed.